netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jiri Pirko <jiri@resnulli.us>
To: netdev@vger.kernel.org
Cc: davem@davemloft.net, idosch@mellanox.com, eladr@mellanox.com,
	yotamg@mellanox.com, nogahf@mellanox.com, arkadis@mellanox.com,
	ogerlitz@mellanox.com, roopa@cumulusnetworks.com,
	dsa@cumulusnetworks.com, nikolay@cumulusnetworks.com,
	andy@greyhouse.net, vivien.didelot@savoirfairelinux.com,
	andrew@lunn.ch, f.fainelli@gmail.com,
	alexander.h.duyck@intel.com, hannes@stressinduktion.org,
	kaber@trash.net
Subject: [patch net-next v3 11/12] mlxsw: spectrum_router: Request a dump of FIB tables during init
Date: Wed, 30 Nov 2016 11:09:05 +0100	[thread overview]
Message-ID: <1480500546-2544-12-git-send-email-jiri@resnulli.us> (raw)
In-Reply-To: <1480500546-2544-1-git-send-email-jiri@resnulli.us>

From: Ido Schimmel <idosch@mellanox.com>

Make sure the device has a complete view of the FIB tables by invoking
their dump during module init.

Signed-off-by: Ido Schimmel <idosch@mellanox.com>
Signed-off-by: Jiri Pirko <jiri@mellanox.com>
---
 .../net/ethernet/mellanox/mlxsw/spectrum_router.c  | 23 ++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c
index 14bed1d..d176047 100644
--- a/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c
+++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c
@@ -2027,8 +2027,23 @@ static int mlxsw_sp_router_fib_event(struct notifier_block *nb,
 	return NOTIFY_DONE;
 }
 
+static void mlxsw_sp_router_fib_dump_flush(struct notifier_block *nb)
+{
+	struct mlxsw_sp *mlxsw_sp = container_of(nb, struct mlxsw_sp, fib_nb);
+
+	/* Flush pending FIB notifications and then flush the device's
+	 * table before requesting another dump. Do that with RTNL held,
+	 * as FIB notification block is already registered.
+	 */
+	mlxsw_core_flush_owq();
+	rtnl_lock();
+	mlxsw_sp_router_fib_flush(mlxsw_sp);
+	rtnl_unlock();
+}
+
 int mlxsw_sp_router_init(struct mlxsw_sp *mlxsw_sp)
 {
+	fib_dump_cb_t *cb = mlxsw_sp_router_fib_dump_flush;
 	int err;
 
 	INIT_LIST_HEAD(&mlxsw_sp->router.nexthop_neighs_list);
@@ -2048,8 +2063,16 @@ int mlxsw_sp_router_init(struct mlxsw_sp *mlxsw_sp)
 
 	mlxsw_sp->fib_nb.notifier_call = mlxsw_sp_router_fib_event;
 	register_fib_notifier(&mlxsw_sp->fib_nb);
+	if (!fib_notifier_dump(&mlxsw_sp->fib_nb, &init_net, cb)) {
+		err = -EBUSY;
+		goto err_fib_notifier_dump;
+	}
+
 	return 0;
 
+err_fib_notifier_dump:
+	unregister_fib_notifier(&mlxsw_sp->fib_nb);
+	mlxsw_sp_neigh_fini(mlxsw_sp);
 err_neigh_init:
 	mlxsw_sp_vrs_fini(mlxsw_sp);
 err_vrs_init:
-- 
2.7.4

  parent reply	other threads:[~2016-11-30 10:09 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-30 10:08 [patch net-next v3 00/12] ipv4: fib: Allow modules to dump FIB tables Jiri Pirko
2016-11-30 10:08 ` [patch net-next v3 01/12] ipv4: fib: Export free_fib_info() Jiri Pirko
2016-11-30 10:08 ` [patch net-next v3 02/12] ipv4: fib: Add fib_info_hold() helper Jiri Pirko
2016-11-30 10:08 ` [patch net-next v3 03/12] mlxsw: core: Create an ordered workqueue for FIB offload Jiri Pirko
2016-11-30 10:08 ` [patch net-next v3 04/12] mlxsw: spectrum_router: Implement FIB offload in deferred work Jiri Pirko
2016-11-30 10:08 ` [patch net-next v3 05/12] rocker: Create an ordered workqueue for FIB offload Jiri Pirko
2016-11-30 10:09 ` [patch net-next v3 06/12] rocker: Implement FIB offload in deferred work Jiri Pirko
2016-11-30 10:09 ` [patch net-next v3 07/12] ipv4: fib: Convert FIB notification chain to be atomic Jiri Pirko
2016-11-30 10:09 ` [patch net-next v3 08/12] ipv4: fib: Allow for consistent FIB dumping Jiri Pirko
2016-11-30 10:09 ` [patch net-next v3 09/12] ipv4: fib: Add sysctl to limit number of FIB dump retries Jiri Pirko
2016-11-30 10:09 ` [patch net-next v3 10/12] ipv4: fib: Add an API to request a FIB dump Jiri Pirko
2016-11-30 10:09 ` Jiri Pirko [this message]
2016-11-30 15:37   ` [patch net-next v3 11/12] mlxsw: spectrum_router: Request a dump of FIB tables during init Hannes Frederic Sowa
2016-11-30 16:32     ` Ido Schimmel
2016-11-30 16:49       ` Hannes Frederic Sowa
2016-11-30 18:22         ` Ido Schimmel
2016-12-01 21:57           ` Hannes Frederic Sowa
2016-12-01 23:14             ` Ido Schimmel
2016-12-01 23:27               ` Hannes Frederic Sowa
2016-12-02  9:34                 ` Ido Schimmel
2016-12-01 20:04       ` David Miller
2016-12-01 20:40         ` Hannes Frederic Sowa
2016-12-01 20:54           ` Ido Schimmel
2016-12-01 21:09             ` Hannes Frederic Sowa
2016-12-01 21:21               ` Ido Schimmel
2016-12-01 21:09       ` Hannes Frederic Sowa
2016-11-30 10:09 ` [patch net-next v3 12/12] rocker: Register FIB notifier before creating ports Jiri Pirko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1480500546-2544-12-git-send-email-jiri@resnulli.us \
    --to=jiri@resnulli.us \
    --cc=alexander.h.duyck@intel.com \
    --cc=andrew@lunn.ch \
    --cc=andy@greyhouse.net \
    --cc=arkadis@mellanox.com \
    --cc=davem@davemloft.net \
    --cc=dsa@cumulusnetworks.com \
    --cc=eladr@mellanox.com \
    --cc=f.fainelli@gmail.com \
    --cc=hannes@stressinduktion.org \
    --cc=idosch@mellanox.com \
    --cc=kaber@trash.net \
    --cc=netdev@vger.kernel.org \
    --cc=nikolay@cumulusnetworks.com \
    --cc=nogahf@mellanox.com \
    --cc=ogerlitz@mellanox.com \
    --cc=roopa@cumulusnetworks.com \
    --cc=vivien.didelot@savoirfairelinux.com \
    --cc=yotamg@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).