From: Jiri Pirko <jiri@resnulli.us>
To: netdev@vger.kernel.org
Cc: davem@davemloft.net, idosch@mellanox.com, eladr@mellanox.com,
yotamg@mellanox.com, nogahf@mellanox.com, arkadis@mellanox.com,
ogerlitz@mellanox.com, roopa@cumulusnetworks.com,
dsa@cumulusnetworks.com, nikolay@cumulusnetworks.com,
andy@greyhouse.net, vivien.didelot@savoirfairelinux.com,
andrew@lunn.ch, f.fainelli@gmail.com,
alexander.h.duyck@intel.com, hannes@stressinduktion.org,
kaber@trash.net
Subject: [patch net-next v3 05/12] rocker: Create an ordered workqueue for FIB offload
Date: Wed, 30 Nov 2016 11:08:59 +0100 [thread overview]
Message-ID: <1480500546-2544-6-git-send-email-jiri@resnulli.us> (raw)
In-Reply-To: <1480500546-2544-1-git-send-email-jiri@resnulli.us>
From: Ido Schimmel <idosch@mellanox.com>
As explained in the previous commits, we need to process FIB entries
addition / deletion events in FIFO order or otherwise we can have a
mismatch between the kernel's FIB table and the device's.
Create an ordered workqueue for rocker to which these work items will be
submitted to.
Signed-off-by: Ido Schimmel <idosch@mellanox.com>
Signed-off-by: Jiri Pirko <jiri@mellanox.com>
---
drivers/net/ethernet/rocker/rocker.h | 1 +
drivers/net/ethernet/rocker/rocker_main.c | 11 +++++++++++
2 files changed, 12 insertions(+)
diff --git a/drivers/net/ethernet/rocker/rocker.h b/drivers/net/ethernet/rocker/rocker.h
index 2eb9b49..ee9675d 100644
--- a/drivers/net/ethernet/rocker/rocker.h
+++ b/drivers/net/ethernet/rocker/rocker.h
@@ -72,6 +72,7 @@ struct rocker {
struct rocker_dma_ring_info event_ring;
struct notifier_block fib_nb;
struct rocker_world_ops *wops;
+ struct workqueue_struct *rocker_owq;
void *wpriv;
};
diff --git a/drivers/net/ethernet/rocker/rocker_main.c b/drivers/net/ethernet/rocker/rocker_main.c
index 67df4cf..424be96 100644
--- a/drivers/net/ethernet/rocker/rocker_main.c
+++ b/drivers/net/ethernet/rocker/rocker_main.c
@@ -28,6 +28,7 @@
#include <linux/if_bridge.h>
#include <linux/bitops.h>
#include <linux/ctype.h>
+#include <linux/workqueue.h>
#include <net/switchdev.h>
#include <net/rtnetlink.h>
#include <net/netevent.h>
@@ -2754,6 +2755,13 @@ static int rocker_probe(struct pci_dev *pdev, const struct pci_device_id *id)
goto err_request_event_irq;
}
+ rocker->rocker_owq = alloc_ordered_workqueue(rocker_driver_name,
+ WQ_MEM_RECLAIM);
+ if (!rocker->rocker_owq) {
+ err = -ENOMEM;
+ goto err_alloc_ordered_workqueue;
+ }
+
rocker->hw.id = rocker_read64(rocker, SWITCH_ID);
err = rocker_probe_ports(rocker);
@@ -2771,6 +2779,8 @@ static int rocker_probe(struct pci_dev *pdev, const struct pci_device_id *id)
return 0;
err_probe_ports:
+ destroy_workqueue(rocker->rocker_owq);
+err_alloc_ordered_workqueue:
free_irq(rocker_msix_vector(rocker, ROCKER_MSIX_VEC_EVENT), rocker);
err_request_event_irq:
free_irq(rocker_msix_vector(rocker, ROCKER_MSIX_VEC_CMD), rocker);
@@ -2799,6 +2809,7 @@ static void rocker_remove(struct pci_dev *pdev)
unregister_fib_notifier(&rocker->fib_nb);
rocker_write32(rocker, CONTROL, ROCKER_CONTROL_RESET);
rocker_remove_ports(rocker);
+ destroy_workqueue(rocker->rocker_owq);
free_irq(rocker_msix_vector(rocker, ROCKER_MSIX_VEC_EVENT), rocker);
free_irq(rocker_msix_vector(rocker, ROCKER_MSIX_VEC_CMD), rocker);
rocker_dma_rings_fini(rocker);
--
2.7.4
next prev parent reply other threads:[~2016-11-30 10:09 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-30 10:08 [patch net-next v3 00/12] ipv4: fib: Allow modules to dump FIB tables Jiri Pirko
2016-11-30 10:08 ` [patch net-next v3 01/12] ipv4: fib: Export free_fib_info() Jiri Pirko
2016-11-30 10:08 ` [patch net-next v3 02/12] ipv4: fib: Add fib_info_hold() helper Jiri Pirko
2016-11-30 10:08 ` [patch net-next v3 03/12] mlxsw: core: Create an ordered workqueue for FIB offload Jiri Pirko
2016-11-30 10:08 ` [patch net-next v3 04/12] mlxsw: spectrum_router: Implement FIB offload in deferred work Jiri Pirko
2016-11-30 10:08 ` Jiri Pirko [this message]
2016-11-30 10:09 ` [patch net-next v3 06/12] rocker: " Jiri Pirko
2016-11-30 10:09 ` [patch net-next v3 07/12] ipv4: fib: Convert FIB notification chain to be atomic Jiri Pirko
2016-11-30 10:09 ` [patch net-next v3 08/12] ipv4: fib: Allow for consistent FIB dumping Jiri Pirko
2016-11-30 10:09 ` [patch net-next v3 09/12] ipv4: fib: Add sysctl to limit number of FIB dump retries Jiri Pirko
2016-11-30 10:09 ` [patch net-next v3 10/12] ipv4: fib: Add an API to request a FIB dump Jiri Pirko
2016-11-30 10:09 ` [patch net-next v3 11/12] mlxsw: spectrum_router: Request a dump of FIB tables during init Jiri Pirko
2016-11-30 15:37 ` Hannes Frederic Sowa
2016-11-30 16:32 ` Ido Schimmel
2016-11-30 16:49 ` Hannes Frederic Sowa
2016-11-30 18:22 ` Ido Schimmel
2016-12-01 21:57 ` Hannes Frederic Sowa
2016-12-01 23:14 ` Ido Schimmel
2016-12-01 23:27 ` Hannes Frederic Sowa
2016-12-02 9:34 ` Ido Schimmel
2016-12-01 20:04 ` David Miller
2016-12-01 20:40 ` Hannes Frederic Sowa
2016-12-01 20:54 ` Ido Schimmel
2016-12-01 21:09 ` Hannes Frederic Sowa
2016-12-01 21:21 ` Ido Schimmel
2016-12-01 21:09 ` Hannes Frederic Sowa
2016-11-30 10:09 ` [patch net-next v3 12/12] rocker: Register FIB notifier before creating ports Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1480500546-2544-6-git-send-email-jiri@resnulli.us \
--to=jiri@resnulli.us \
--cc=alexander.h.duyck@intel.com \
--cc=andrew@lunn.ch \
--cc=andy@greyhouse.net \
--cc=arkadis@mellanox.com \
--cc=davem@davemloft.net \
--cc=dsa@cumulusnetworks.com \
--cc=eladr@mellanox.com \
--cc=f.fainelli@gmail.com \
--cc=hannes@stressinduktion.org \
--cc=idosch@mellanox.com \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
--cc=nikolay@cumulusnetworks.com \
--cc=nogahf@mellanox.com \
--cc=ogerlitz@mellanox.com \
--cc=roopa@cumulusnetworks.com \
--cc=vivien.didelot@savoirfairelinux.com \
--cc=yotamg@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).