* [PATCH net] RDS: TCP: unregister_netdevice_notifier() in error path of rds_tcp_init_net
@ 2016-12-01 12:44 Sowmini Varadhan
2016-12-01 16:40 ` Santosh Shilimkar
2016-12-02 18:30 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Sowmini Varadhan @ 2016-12-01 12:44 UTC (permalink / raw)
To: sowmini.varadhan, netdev, sowmini.varadhan; +Cc: davem, santosh.shilimkar
If some error is encountered in rds_tcp_init_net, make sure to
unregister_netdevice_notifier(), else we could trigger a panic
later on, when the modprobe from a netns fails.
Signed-off-by: Sowmini Varadhan <sowmini.varadhan@oracle.com>
---
net/rds/tcp.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/net/rds/tcp.c b/net/rds/tcp.c
index fcddacc..20e2923 100644
--- a/net/rds/tcp.c
+++ b/net/rds/tcp.c
@@ -659,6 +659,8 @@ static int rds_tcp_init(void)
out_pernet:
unregister_pernet_subsys(&rds_tcp_net_ops);
out_slab:
+ if (unregister_netdevice_notifier(&rds_tcp_dev_notifier))
+ pr_warn("could not unregister rds_tcp_dev_notifier\n");
kmem_cache_destroy(rds_tcp_conn_slab);
out:
return ret;
--
1.7.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net] RDS: TCP: unregister_netdevice_notifier() in error path of rds_tcp_init_net
2016-12-01 12:44 [PATCH net] RDS: TCP: unregister_netdevice_notifier() in error path of rds_tcp_init_net Sowmini Varadhan
@ 2016-12-01 16:40 ` Santosh Shilimkar
2016-12-02 18:30 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Santosh Shilimkar @ 2016-12-01 16:40 UTC (permalink / raw)
To: Sowmini Varadhan, netdev; +Cc: davem
On 12/1/2016 4:44 AM, Sowmini Varadhan wrote:
> If some error is encountered in rds_tcp_init_net, make sure to
> unregister_netdevice_notifier(), else we could trigger a panic
> later on, when the modprobe from a netns fails.
>
> Signed-off-by: Sowmini Varadhan <sowmini.varadhan@oracle.com>
> ---
Acked-by: Santosh Shilimkar <santosh.shilimkar@oracle.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net] RDS: TCP: unregister_netdevice_notifier() in error path of rds_tcp_init_net
2016-12-01 12:44 [PATCH net] RDS: TCP: unregister_netdevice_notifier() in error path of rds_tcp_init_net Sowmini Varadhan
2016-12-01 16:40 ` Santosh Shilimkar
@ 2016-12-02 18:30 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2016-12-02 18:30 UTC (permalink / raw)
To: sowmini.varadhan; +Cc: netdev, santosh.shilimkar
From: Sowmini Varadhan <sowmini.varadhan@oracle.com>
Date: Thu, 1 Dec 2016 04:44:43 -0800
> If some error is encountered in rds_tcp_init_net, make sure to
> unregister_netdevice_notifier(), else we could trigger a panic
> later on, when the modprobe from a netns fails.
>
> Signed-off-by: Sowmini Varadhan <sowmini.varadhan@oracle.com>
Applied, thank you.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-12-02 18:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-12-01 12:44 [PATCH net] RDS: TCP: unregister_netdevice_notifier() in error path of rds_tcp_init_net Sowmini Varadhan
2016-12-01 16:40 ` Santosh Shilimkar
2016-12-02 18:30 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).