* [PATCH iproute2] Makefile: really suppress printing of directories
@ 2016-12-07 20:55 David Ahern
2016-12-09 20:50 ` Stephen Hemminger
0 siblings, 1 reply; 3+ messages in thread
From: David Ahern @ 2016-12-07 20:55 UTC (permalink / raw)
To: netdev, stephen; +Cc: David Ahern
Makefile adds --no-print-directory to MAKEFLAGS if VERBOSE is not
defined however Config always defines VERBOSE. Update the check to
whether VERBOSE is 0.
Fixes: 57bdf8b76451 ("Make builds default to quiet mode")
Signed-off-by: David Ahern <dsa@cumulusnetworks.com>
---
Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile b/Makefile
index 37b68ad87f06..18de7dcb315b 100644
--- a/Makefile
+++ b/Makefile
@@ -3,7 +3,7 @@ ifneq ($(wildcard Config),)
include Config
endif
-ifndef VERBOSE
+ifeq ($(VERBOSE),0)
MAKEFLAGS += --no-print-directory
endif
--
2.1.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH iproute2] Makefile: really suppress printing of directories
2016-12-07 20:55 [PATCH iproute2] Makefile: really suppress printing of directories David Ahern
@ 2016-12-09 20:50 ` Stephen Hemminger
2016-12-09 22:05 ` David Ahern
0 siblings, 1 reply; 3+ messages in thread
From: Stephen Hemminger @ 2016-12-09 20:50 UTC (permalink / raw)
To: David Ahern; +Cc: netdev
On Wed, 7 Dec 2016 12:55:09 -0800
David Ahern <dsa@cumulusnetworks.com> wrote:
> Makefile adds --no-print-directory to MAKEFLAGS if VERBOSE is not
> defined however Config always defines VERBOSE. Update the check to
> whether VERBOSE is 0.
>
> Fixes: 57bdf8b76451 ("Make builds default to quiet mode")
> Signed-off-by: David Ahern <dsa@cumulusnetworks.com>
Applied to net-next.
Patch only works with net-next, please label it next time.
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH iproute2] Makefile: really suppress printing of directories
2016-12-09 20:50 ` Stephen Hemminger
@ 2016-12-09 22:05 ` David Ahern
0 siblings, 0 replies; 3+ messages in thread
From: David Ahern @ 2016-12-09 22:05 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: netdev
On 12/9/16 12:50 PM, Stephen Hemminger wrote:
> On Wed, 7 Dec 2016 12:55:09 -0800
> David Ahern <dsa@cumulusnetworks.com> wrote:
>
>> Makefile adds --no-print-directory to MAKEFLAGS if VERBOSE is not
>> defined however Config always defines VERBOSE. Update the check to
>> whether VERBOSE is 0.
>>
>> Fixes: 57bdf8b76451 ("Make builds default to quiet mode")
>> Signed-off-by: David Ahern <dsa@cumulusnetworks.com>
>
> Applied to net-next.
>
> Patch only works with net-next, please label it next time.
>
That does not sound right. The patch this one fixes was applied back in May, and Makefile has only had one other commit against it since.
Regardless, I will add the label to git to default to net-next.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-12-09 22:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-12-07 20:55 [PATCH iproute2] Makefile: really suppress printing of directories David Ahern
2016-12-09 20:50 ` Stephen Hemminger
2016-12-09 22:05 ` David Ahern
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).