From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: "Keller, Jacob E" <jacob.e.keller@intel.com>,
Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
"davem@davemloft.net" <davem@davemloft.net>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"nhorman@redhat.com" <nhorman@redhat.com>,
"sassmann@redhat.com" <sassmann@redhat.com>,
"jogreene@redhat.com" <jogreene@redhat.com>,
"guru.anbalagane@oracle.com" <guru.anbalagane@oracle.com>
Subject: Re: [net-next 20/20] i40e: don't allow i40e_vsi_(add|kill)_vlan to operate when VID<1
Date: Wed, 07 Dec 2016 13:53:14 -0800 [thread overview]
Message-ID: <1481147594.2404.22.camel@intel.com> (raw)
In-Reply-To: <02874ECE860811409154E81DA85FBB5857CD9C6D@ORSMSX115.amr.corp.intel.com>
[-- Attachment #1: Type: text/plain, Size: 1182 bytes --]
On Wed, 2016-12-07 at 13:50 -0800, Keller, Jacob E wrote:
> > -----Original Message-----
> > From: Sergei Shtylyov [mailto:sergei.shtylyov@cogentembedded.com]
> > Sent: Wednesday, December 07, 2016 2:11 AM
> > To: Kirsher, Jeffrey T <jeffrey.t.kirsher@intel.com>; davem@davemloft.n
> > et
> > Cc: Keller, Jacob E <jacob.e.keller@intel.com>; netdev@vger.kernel.org;
> > nhorman@redhat.com; sassmann@redhat.com; jogreene@redhat.com;
> > guru.anbalagane@oracle.com
> > Subject: Re: [net-next 20/20] i40e: don't allow
> > i40e_vsi_(add|kill)_vlan to operate
> > when VID<1
> >
> > Hello!
> > > + if (!(vid > 0) || vsi->info.pvid)
> >
> > Why not just '!vid'?
>
> Left over artifact of this previously being a signed value. We can fix
> this.
>
> Thanks,
> Jake
>
> > > -void i40e_vsi_kill_vlan(struct i40e_vsi *vsi, s16 vid)
> > > +void i40e_vsi_kill_vlan(struct i40e_vsi *vsi, u16 vid)
> > > {
> > > + if (!(vid > 0) || vsi->info.pvid)
> >
> > Likewise.
>
> Same here. Can get this fixed.
While you are fixing this up and sending me a new version of this patch, I
will just drop this from the series and re-send.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-12-07 21:53 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-07 7:33 [net-next 00/20][pull request] 40GbE Intel Wired LAN Driver Updates 2016-12-06 Jeff Kirsher
2016-12-07 7:33 ` [net-next 01/20] i40e: Driver prints log message on link speed change Jeff Kirsher
2016-12-07 7:33 ` [net-next 02/20] i40e: simplify txd use count calculation Jeff Kirsher
2016-12-07 7:33 ` [net-next 03/20] i40e: restore workaround for removing default MAC filter Jeff Kirsher
2016-12-07 7:33 ` [net-next 04/20] i40e/i40evf: napi_poll must return the work done Jeff Kirsher
2016-12-07 7:33 ` [net-next 05/20] i40e: remove code to handle dev_addr specially Jeff Kirsher
2016-12-07 7:33 ` [net-next 06/20] i40e: Blink LED on 1G BaseT boards Jeff Kirsher
2016-12-07 7:33 ` [net-next 07/20] Changed version from 1.6.21 to 1.6.25 Jeff Kirsher
2016-12-07 7:33 ` [net-next 08/20] i40e: use unsigned printf format specifier for active_filters count Jeff Kirsher
2016-12-07 7:33 ` [net-next 09/20] i40e: Add support for 25G devices Jeff Kirsher
2016-12-07 7:33 ` [net-next 10/20] i40e: Add FEC for 25g Jeff Kirsher
2016-12-07 7:33 ` [net-next 11/20] i40e: Add functions which apply correct PHY access method for read and write operation Jeff Kirsher
2016-12-07 7:33 ` [net-next 12/20] i40e: lock service task correctly Jeff Kirsher
2016-12-07 7:33 ` [net-next 13/20] i40e: defeature support for PTP L4 frame detection on XL710 Jeff Kirsher
2016-12-07 7:33 ` [net-next 14/20] i40e: recalculate vsi->active_filters from hash contents Jeff Kirsher
2016-12-07 7:33 ` [net-next 15/20] i40e: refactor i40e_update_filter_state to avoid passing aq_err Jeff Kirsher
2016-12-07 7:33 ` [net-next 16/20] i40e: delete filter after adding its replacement when converting Jeff Kirsher
2016-12-07 7:33 ` [net-next 17/20] i40e: factor out addition/deletion of VLAN per each MAC address Jeff Kirsher
2016-12-07 7:33 ` [net-next 18/20] i40e: use (add|rm)_vlan_all_mac helper functions when changing PVID Jeff Kirsher
2016-12-07 7:33 ` [net-next 19/20] i40e: move all updates for VLAN mode into i40e_sync_vsi_filters Jeff Kirsher
2016-12-07 7:33 ` [net-next 20/20] i40e: don't allow i40e_vsi_(add|kill)_vlan to operate when VID<1 Jeff Kirsher
2016-12-07 10:10 ` Sergei Shtylyov
2016-12-07 21:50 ` Keller, Jacob E
2016-12-07 21:53 ` Jeff Kirsher [this message]
2016-12-07 22:00 ` Keller, Jacob E
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1481147594.2404.22.camel@intel.com \
--to=jeffrey.t.kirsher@intel.com \
--cc=davem@davemloft.net \
--cc=guru.anbalagane@oracle.com \
--cc=jacob.e.keller@intel.com \
--cc=jogreene@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@redhat.com \
--cc=sassmann@redhat.com \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).