* [PATCH-RESEND] vhost-vsock: fix orphan connection reset
@ 2016-12-08 17:10 Peng Tao
2016-12-09 2:25 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Peng Tao @ 2016-12-08 17:10 UTC (permalink / raw)
To: Stefan Hajnoczi; +Cc: David Miller, kvm, virtualization, netdev
local_addr.svm_cid is host cid. We should check guest cid instead,
which is remote_addr.svm_cid. Otherwise we end up resetting all
connections to all guests.
Cc: stable@vger.kernel.org [4.8+]
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Peng Tao <bergwolf@gmail.com>
---
resending because the last attempt looks to be dropped by vger.
drivers/vhost/vsock.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/vhost/vsock.c b/drivers/vhost/vsock.c
index e3b30ea..a504e2e0 100644
--- a/drivers/vhost/vsock.c
+++ b/drivers/vhost/vsock.c
@@ -506,7 +506,7 @@ static void vhost_vsock_reset_orphans(struct sock *sk)
* executing.
*/
- if (!vhost_vsock_get(vsk->local_addr.svm_cid)) {
+ if (!vhost_vsock_get(vsk->remote_addr.svm_cid)) {
sock_set_flag(sk, SOCK_DONE);
vsk->peer_shutdown = SHUTDOWN_MASK;
sk->sk_state = SS_UNCONNECTED;
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH-RESEND] vhost-vsock: fix orphan connection reset
2016-12-08 17:10 [PATCH-RESEND] vhost-vsock: fix orphan connection reset Peng Tao
@ 2016-12-09 2:25 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2016-12-09 2:25 UTC (permalink / raw)
To: bergwolf; +Cc: stefanha, kvm, virtualization, netdev
From: Peng Tao <bergwolf@gmail.com>
Date: Fri, 9 Dec 2016 01:10:46 +0800
> local_addr.svm_cid is host cid. We should check guest cid instead,
> which is remote_addr.svm_cid. Otherwise we end up resetting all
> connections to all guests.
>
> Cc: stable@vger.kernel.org [4.8+]
> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
> Signed-off-by: Peng Tao <bergwolf@gmail.com>
Applied and queued up for -stable, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-12-09 2:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-12-08 17:10 [PATCH-RESEND] vhost-vsock: fix orphan connection reset Peng Tao
2016-12-09 2:25 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).