netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Peng Tao <bergwolf@gmail.com>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: David Miller <davem@davemloft.net>,
	kvm@vger.kernel.org, virtualization@lists.linux-foundation.org,
	netdev@vger.kernel.org, Jorgen Hansen <jhansen@vmware.com>
Subject: [PATCH v3 0/4] vsock: cancel connect packets when failing to connect
Date: Fri,  9 Dec 2016 01:12:32 +0800	[thread overview]
Message-ID: <1481217156-7160-1-git-send-email-bergwolf@gmail.com> (raw)

Currently, if a connect call fails on a signal or timeout (e.g., guest is still
in the process of starting up), we'll just return to caller and leave the connect
packet queued and they are sent even though the connection is considered a failure,
which can confuse applications with unwanted false connect attempt.

The patchset enables vsock (both host and guest) to cancel queued packets when
a connect attempt is considered to fail.

v3 changelog:
  - define cancel_pkt callback in struct vsock_transport rather than struct virtio_transport
  - rename virtio_vsock_pkt->vsk to virtio_vsock_pkt->cancel_token
v2 changelog:
  - fix queued_replies counting and resume tx/rx when necessary


Peng Tao (4):
  vsock: track pkt owner vsock
  vhost-vsock: add pkt cancel capability
  vsock: add pkt cancel capability
  vsock: cancel packets when failing to connect

 drivers/vhost/vsock.c                   | 41 ++++++++++++++++++++++++++++++++
 include/linux/virtio_vsock.h            |  2 ++
 include/net/af_vsock.h                  |  3 +++
 net/vmw_vsock/af_vsock.c                | 14 +++++++++++
 net/vmw_vsock/virtio_transport.c        | 42 +++++++++++++++++++++++++++++++++
 net/vmw_vsock/virtio_transport_common.c |  7 ++++++
 6 files changed, 109 insertions(+)

-- 
2.7.4

             reply	other threads:[~2016-12-08 17:13 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-08 17:12 Peng Tao [this message]
2016-12-08 17:12 ` [PATCH v3 1/4] vsock: track pkt owner vsock Peng Tao
2016-12-08 17:12   ` [PATCH v3 2/4] vhost-vsock: add pkt cancel capability Peng Tao
2016-12-08 17:12     ` [PATCH v3 3/4] vsock: " Peng Tao
2016-12-08 17:12       ` [PATCH v3 4/4] vsock: cancel packets when failing to connect Peng Tao
2016-12-09 10:17         ` Stefan Hajnoczi
2016-12-12 10:41         ` Jorgen S. Hansen
2016-12-09 10:16       ` [PATCH v3 3/4] vsock: add pkt cancel capability Stefan Hajnoczi
2016-12-09 10:15     ` [PATCH v3 2/4] vhost-vsock: " Stefan Hajnoczi
2016-12-12 10:37     ` Jorgen S. Hansen
2016-12-12 11:56       ` Peng Tao
2016-12-09 10:18 ` [PATCH v3 0/4] vsock: cancel connect packets when failing to connect Stefan Hajnoczi
2016-12-12  9:17   ` Peng Tao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1481217156-7160-1-git-send-email-bergwolf@gmail.com \
    --to=bergwolf@gmail.com \
    --cc=davem@davemloft.net \
    --cc=jhansen@vmware.com \
    --cc=kvm@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=stefanha@redhat.com \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).