* [PATCH iproute2] Fix compile warning in get_addr_1
@ 2016-12-13 23:34 David Ahern
2016-12-15 3:30 ` Stephen Hemminger
0 siblings, 1 reply; 2+ messages in thread
From: David Ahern @ 2016-12-13 23:34 UTC (permalink / raw)
To: netdev, stephen; +Cc: David Ahern
A recent cleanup causes a compile warning on Debian jessie:
CC utils.o
utils.c: In function ‘get_addr_1’:
utils.c:486:21: warning: passing argument 1 of ‘ll_addr_a2n’ from incompatible pointer type
len = ll_addr_a2n(&addr->data, sizeof(addr->data), name);
^
In file included from utils.c:34:0:
../include/rt_names.h:27:5: note: expected ‘char *’ but argument is of type ‘__u32 (*)[8]’
int ll_addr_a2n(char *lladdr, int len, const char *arg);
^
Revert the removal of the typecast
Fixes: e1933b928125 ("utils: cleanup style")
Signed-off-by: David Ahern <dsa@cumulusnetworks.com>
---
lib/utils.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/lib/utils.c b/lib/utils.c
index 316b048abcfc..83c9d097c608 100644
--- a/lib/utils.c
+++ b/lib/utils.c
@@ -483,7 +483,8 @@ int get_addr_1(inet_prefix *addr, const char *name, int family)
if (family == AF_PACKET) {
int len;
- len = ll_addr_a2n(&addr->data, sizeof(addr->data), name);
+ len = ll_addr_a2n((char *) &addr->data, sizeof(addr->data),
+ name);
if (len < 0)
return -1;
--
2.1.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH iproute2] Fix compile warning in get_addr_1
2016-12-13 23:34 [PATCH iproute2] Fix compile warning in get_addr_1 David Ahern
@ 2016-12-15 3:30 ` Stephen Hemminger
0 siblings, 0 replies; 2+ messages in thread
From: Stephen Hemminger @ 2016-12-15 3:30 UTC (permalink / raw)
To: David Ahern; +Cc: netdev
On Tue, 13 Dec 2016 15:34:32 -0800
David Ahern <dsa@cumulusnetworks.com> wrote:
> A recent cleanup causes a compile warning on Debian jessie:
>
> CC utils.o
> utils.c: In function ‘get_addr_1’:
> utils.c:486:21: warning: passing argument 1 of ‘ll_addr_a2n’ from incompatible pointer type
> len = ll_addr_a2n(&addr->data, sizeof(addr->data), name);
> ^
> In file included from utils.c:34:0:
> ../include/rt_names.h:27:5: note: expected ‘char *’ but argument is of type ‘__u32 (*)[8]’
> int ll_addr_a2n(char *lladdr, int len, const char *arg);
> ^
>
> Revert the removal of the typecast
>
> Fixes: e1933b928125 ("utils: cleanup style")
> Signed-off-by: David Ahern <dsa@cumulusnetworks.com>
> ---
> lib/utils.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/lib/utils.c b/lib/utils.c
> index 316b048abcfc..83c9d097c608 100644
> --- a/lib/utils.c
> +++ b/lib/utils.c
> @@ -483,7 +483,8 @@ int get_addr_1(inet_prefix *addr, const char *name, int family)
> if (family == AF_PACKET) {
> int len;
>
> - len = ll_addr_a2n(&addr->data, sizeof(addr->data), name);
> + len = ll_addr_a2n((char *) &addr->data, sizeof(addr->data),
> + name);
> if (len < 0)
> return -1;
>
Thanks was accidental.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-12-15 3:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-12-13 23:34 [PATCH iproute2] Fix compile warning in get_addr_1 David Ahern
2016-12-15 3:30 ` Stephen Hemminger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).