From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Blakey Subject: [PATCH net 2/2] net/sched: cls_flower: Use masked key when calling HW offloads Date: Wed, 14 Dec 2016 19:00:58 +0200 Message-ID: <1481734858-37474-3-git-send-email-paulb@mellanox.com> References: <1481734858-37474-1-git-send-email-paulb@mellanox.com> Cc: Jiri Pirko , Or Gerlitz , Roi Dayan , Shahar Klein , Hadar Hen Zion , Paul Blakey To: "David S. Miller" , netdev@vger.kernel.org Return-path: Received: from mail-il-dmz.mellanox.com ([193.47.165.129]:44451 "EHLO mellanox.co.il" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753943AbcLNRID (ORCPT ); Wed, 14 Dec 2016 12:08:03 -0500 In-Reply-To: <1481734858-37474-1-git-send-email-paulb@mellanox.com> Sender: netdev-owner@vger.kernel.org List-ID: Zero bits on the mask signify a "don't care" on the corresponding bits in key. Some HWs require those bits on the key to be zero. Since these bits are masked anyway, it's okay to provide the masked key to all drivers. Fixes: 5b33f48842fa ('net/flower: Introduce hardware offload support') Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Acked-by: Jiri Pirko --- net/sched/cls_flower.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/sched/cls_flower.c b/net/sched/cls_flower.c index 9758f5a..35ac28d 100644 --- a/net/sched/cls_flower.c +++ b/net/sched/cls_flower.c @@ -252,7 +252,7 @@ static int fl_hw_replace_filter(struct tcf_proto *tp, offload.cookie = (unsigned long)f; offload.dissector = dissector; offload.mask = mask; - offload.key = &f->key; + offload.key = &f->mkey; offload.exts = &f->exts; tc->type = TC_SETUP_CLSFLOWER; -- 1.8.3.1