From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jerome Brunet Subject: [PATCH net 1/3] net: phy: fix sign type error in genphy_config_eee_advert Date: Mon, 19 Dec 2016 16:05:36 +0100 Message-ID: <1482159938-13239-2-git-send-email-jbrunet@baylibre.com> References: <1482159938-13239-1-git-send-email-jbrunet@baylibre.com> Cc: Jerome Brunet , Carlo Caione , Kevin Hilman , Martin Blumenstingl , Andre Roth , Andrew Lunn , Neil Armstrong , linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Julia Lawall , Yegor Yefremov , =?UTF-8?q?Andreas=20F=C3=A4rber?= To: netdev@vger.kernel.org, devicetree@vger.kernel.org, Florian Fainelli Return-path: Received: from mail-wm0-f46.google.com ([74.125.82.46]:37324 "EHLO mail-wm0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1762389AbcLSPFt (ORCPT ); Mon, 19 Dec 2016 10:05:49 -0500 Received: by mail-wm0-f46.google.com with SMTP id t79so103465011wmt.0 for ; Mon, 19 Dec 2016 07:05:49 -0800 (PST) In-Reply-To: <1482159938-13239-1-git-send-email-jbrunet@baylibre.com> Sender: netdev-owner@vger.kernel.org List-ID: In genphy_config_eee_advert, the return value of phy_read_mmd_indirect is checked to know if the register could be accessed but the result is assigned to a 'u32'. Changing to 'int' to correctly get errors from phy_read_mmd_indirect. Fixes: d853d145ea3e ("net: phy: add an option to disable EEE advertisement") Reported-by: Julia Lawall Signed-off-by: Jerome Brunet --- drivers/net/phy/phy_device.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c index 9c06f8028f0c..ee5ebadb1463 100644 --- a/drivers/net/phy/phy_device.c +++ b/drivers/net/phy/phy_device.c @@ -1187,8 +1187,8 @@ static int genphy_config_advert(struct phy_device *phydev) */ static int genphy_config_eee_advert(struct phy_device *phydev) { - u32 broken = phydev->eee_broken_modes; - u32 old_adv, adv; + int broken = phydev->eee_broken_modes; + int old_adv, adv; /* Nothing to disable */ if (!broken) -- 2.7.4