From: Johannes Berg <johannes@sipsolutions.net>
To: linux-wireless@vger.kernel.org
Cc: netdev@vger.kernel.org, Guiming Zhuo <gmzhuo@gmail.com>,
Antonio Ospite <ospite@studenti.unina.it>,
Paul Cercueil <paul@crapouillou.net>,
Rob Herring <robh+dt@kernel.org>,
Maarten ter Huurne <maarten@treewalker.org>
Subject: Re: [PATCH] rfkill: remove rfkill-regulator
Date: Mon, 02 Jan 2017 16:03:56 +0100 [thread overview]
Message-ID: <1483369436.21014.12.camel@sipsolutions.net> (raw)
In-Reply-To: <20170102150157.26745-1-johannes@sipsolutions.net> (sfid-20170102_160217_157310_15217E5D)
On Mon, 2017-01-02 at 16:01 +0100, Johannes Berg wrote:
> From: Johannes Berg <johannes.berg@intel.com>
>
> There are no users of this ("vrfkill") in the tree, so it's just
> dead code - remove it.
>
> This also isn't really how rfkill is supposed to be used - it's
> intended as a signalling mechanism to/from the device, which the
> driver (and partially cfg80211) will handle - having a separate
> rfkill instance for a regulator is confusing, the driver should
> use the regulator instead to turn off the device when requested.
OTOH, the rfkill-gpio is essentially the same thing, and it *does* get
used - by ACPI even, to control a GPS chip. And I'm not even sure that
there's a clear place to put this since there probably aren't any GPS
drivers?
johannes
prev parent reply other threads:[~2017-01-02 15:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-02 15:01 [PATCH] rfkill: remove rfkill-regulator Johannes Berg
2017-01-02 15:03 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1483369436.21014.12.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=gmzhuo@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=maarten@treewalker.org \
--cc=netdev@vger.kernel.org \
--cc=ospite@studenti.unina.it \
--cc=paul@crapouillou.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).