From: Johannes Berg <johannes@sipsolutions.net>
To: Jorge Ramirez <jorge.ramirez-ortiz@linaro.org>,
netdev@vger.kernel.org,
Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: SIOCSIWFREQ while in NL80211_IFTYPE_STATION
Date: Thu, 05 Jan 2017 15:06:44 +0100 [thread overview]
Message-ID: <1483625204.4394.23.camel@sipsolutions.net> (raw)
In-Reply-To: <92e60cb2-8bb4-df03-3434-4a055f575df0@linaro.org> (sfid-20170105_142703_879207_374EBEEC)
> I am not sure it matters - if I understood your reply, there is no
> valid use case to change the frequency in that mode (and all that
> code should be removed);
All of wext *is* being removed - slowly :)
It's not longer default in the kernel configuration now.
IIRC, there actually was a valid use case here - to set the frequency
before you set the SSID - to be able to force a connection on that
channel with wext.
> it seems to me that it is also your view that userspace (iwconfig)
> should be fixed accordingly to not call the extensions?
iwconfig should just be deleted and iw be used :-)
> I am just trying to understand how the current code is supposed to
> work by exercising widely available user-space tools while debugging
> the kernel.
Heh, ok.
> Actually the frequency gets programmed without errors when reverting
> your commit http://tinyurl.com/ho4urp8 (which comes as a surprise as
> well).
Well, it's not my commit, but that makes sense. I suppose we should
treat this as a regression, but reverting that doesn't seem like the
right fix. Actually, I'm not convinced we should do monitor channel
change anyway when you set the frequency with wext, so we can probably
just remove that call there - want to send a patch to that effect?
johannes
next prev parent reply other threads:[~2017-01-05 14:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-05 11:02 SIOCSIWFREQ while in NL80211_IFTYPE_STATION Jorge Ramirez
[not found] ` <685811c3-6247-77fd-8c70-617951886451-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2017-01-05 11:38 ` Johannes Berg
2017-01-05 13:27 ` Jorge Ramirez
2017-01-05 14:06 ` Johannes Berg [this message]
2017-01-05 14:38 ` Jorge Ramirez
[not found] ` <f8e8b557-3e7b-cc1a-c31a-91f9d754e683-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2017-01-09 11:05 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1483625204.4394.23.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=daniel.lezcano@linaro.org \
--cc=jorge.ramirez-ortiz@linaro.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).