From: Johannes Berg <johannes@sipsolutions.net>
To: "Michał Kępień" <kernel@kempniu.pl>,
"David S . Miller" <davem@davemloft.net>
Cc: "Михаил Кринкин" <krinkin.m.u@gmail.com>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] rfkill: Add rfkill-any LED trigger
Date: Fri, 06 Jan 2017 13:22:13 +0100 [thread overview]
Message-ID: <1483705333.4089.6.camel@sipsolutions.net> (raw)
In-Reply-To: <20170106060747.6162-1-kernel@kempniu.pl> (sfid-20170106_070815_740015_7BAF878D)
On Fri, 2017-01-06 at 07:07 +0100, Michał Kępień wrote:
> Add a new "global" (i.e. not per-rfkill device) LED trigger, rfkill-
> any,
> which may be useful on laptops with a single "radio LED" and multiple
> radio transmitters. The trigger is meant to turn a LED on whenever
> there is at least one radio transmitter active and turn it off
> otherwise.
>
> Signed-off-by: Michał Kępień <kernel@kempniu.pl>
> ---
> Changes from v3:
>
> - Revert introducing a new bitfield and instead defer LED event
> firing
> to a work queue to prevent conditional locking and ensure the
> trigger can really be used from any context. This also voids the
> need to take rfkill_global_mutex before calling
> rfkill_set_block()
> in rfkill_resume().
Looks better, but
> +static struct work_struct rfkill_any_work;
At least on module exit you need to cancel this work.
johannes
next prev parent reply other threads:[~2017-01-06 12:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-06 6:07 [PATCH v4] rfkill: Add rfkill-any LED trigger Michał Kępień
2017-01-06 12:22 ` Johannes Berg [this message]
[not found] ` <1483705333.4089.6.camel-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
2017-01-06 19:20 ` Michał Kępień
2017-01-09 10:39 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1483705333.4089.6.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=davem@davemloft.net \
--cc=kernel@kempniu.pl \
--cc=krinkin.m.u@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).