netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Doug Ledford <dledford@redhat.com>
To: Michael Chan <michael.chan@broadcom.com>,
	David Miller <davem@davemloft.net>,
	Selvin Xavier <selvin.xavier@broadcom.com>
Cc: Netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next 5/6] bnxt_en: Pass RoCE app priority to firmware.
Date: Wed, 11 Jan 2017 13:34:08 -0500	[thread overview]
Message-ID: <1484159648.2149.42.camel@redhat.com> (raw)
In-Reply-To: <CACKFLi=6Nt0hr59zA1BpFNH+_q_kU3eR+F6WFOBwFJ03-RzaEg@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1560 bytes --]

On Wed, 2017-01-11 at 09:17 -0800, Michael Chan wrote:
> On Wed, Jan 11, 2017 at 7:46 AM, David Miller <davem@davemloft.net>
> wrote:
> > 
> > From: Michael Chan <michael.chan@broadcom.com>
> > Date: Tue, 10 Jan 2017 20:12:38 -0500
> > 
> > > 
> > > diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_dcb.h
> > > b/drivers/net/ethernet/broadcom/bnxt/bnxt_dcb.h
> > > index 35a0d28..f2630cc 100644
> > > --- a/drivers/net/ethernet/broadcom/bnxt/bnxt_dcb.h
> > > +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_dcb.h
> > > @@ -36,6 +36,9 @@ struct bnxt_cos2bw_cfg {
> > > 
> > >  #define HWRM_STRUCT_DATA_SUBTYPE_HOST_OPERATIONAL    0x0300
> > > 
> > > +#define ETH_P_ROCE           0x8915
> > 
> > There's also a similar define in the qedr infiniband driver, this
> > doesn't
> > make much sense.
> > 
> > Please add this to if_ether.h, and reference it from there in the
> > drivers.
> > 
> My colleague informed me that he has submitted a patch to do that
> through the rdma tree:
> 
> http://marc.info/?l=linux-rdma&m=148217575500983&w=2
> 
> But it hasn't been merged yet.  I can drop this patch now and wait
> for
> the RDMA patch to show up on net-next. Or I make the change later to
> use the common define when the RDMA patch is merged.  Thanks.

The patch for this is in my for-next area:

69ae543969ab RDMA: Adding ethertype ETH_P_IBOE

-- 
Doug Ledford <dledford@redhat.com>
    GPG KeyID: B826A3330E572FDD
   
Key fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

  reply	other threads:[~2017-01-11 18:34 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-11  1:12 [PATCH net-next 0/6] bnxt_en: Misc. updates for net-next Michael Chan
2017-01-11  1:12 ` [PATCH net-next 1/6] bnxt_en: Fix compiler warnings when CONFIG_RFS_ACCEL is not defined Michael Chan
2017-01-11  1:12 ` [PATCH net-next 2/6] bnxt_en: Clear TPA flags when BNXT_FLAG_NO_AGG_RINGS is set Michael Chan
2017-01-11  1:12 ` [PATCH net-next 3/6] bnxt_en: Update to firmware interface spec to 1.6.1 Michael Chan
2017-01-11  1:12 ` [PATCH net-next 4/6] bnxt_en: Add support for ethtool -p Michael Chan
2017-01-11  1:12 ` [PATCH net-next 5/6] bnxt_en: Pass RoCE app priority to firmware Michael Chan
2017-01-11 15:46   ` David Miller
2017-01-11 17:17     ` Michael Chan
2017-01-11 18:34       ` Doug Ledford [this message]
2017-01-11 19:53         ` Michael Chan
2017-01-11  1:12 ` [PATCH net-next 6/6] bnxt_en: Add the ulp_sriov_cfg hooks for bnxt_re RDMA driver Michael Chan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1484159648.2149.42.camel@redhat.com \
    --to=dledford@redhat.com \
    --cc=davem@davemloft.net \
    --cc=michael.chan@broadcom.com \
    --cc=netdev@vger.kernel.org \
    --cc=selvin.xavier@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).