From: Cong Wang <xiyou.wangcong@gmail.com>
To: netdev@vger.kernel.org
Cc: mhocko@kernel.org, romieu@fr.zoreil.com, 3chas3@gmail.com,
andreyknvl@google.com, Cong Wang <xiyou.wangcong@gmail.com>
Subject: [Patch net] atm: remove an unnecessary loop
Date: Wed, 11 Jan 2017 21:02:01 -0800 [thread overview]
Message-ID: <1484197322-958-1-git-send-email-xiyou.wangcong@gmail.com> (raw)
alloc_tx() is already inside a wait loop for a successful skb
allocation, this loop inside alloc_tx() is quite unnecessary
and actually problematic.
Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
---
net/atm/common.c | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/net/atm/common.c b/net/atm/common.c
index a3ca922..7ec3bbc 100644
--- a/net/atm/common.c
+++ b/net/atm/common.c
@@ -72,10 +72,11 @@ static struct sk_buff *alloc_tx(struct atm_vcc *vcc, unsigned int size)
sk_wmem_alloc_get(sk), size, sk->sk_sndbuf);
return NULL;
}
- while (!(skb = alloc_skb(size, GFP_KERNEL)))
- schedule();
- pr_debug("%d += %d\n", sk_wmem_alloc_get(sk), skb->truesize);
- atomic_add(skb->truesize, &sk->sk_wmem_alloc);
+ skb = alloc_skb(size, GFP_KERNEL);
+ if (skb) {
+ pr_debug("%d += %d\n", sk_wmem_alloc_get(sk), skb->truesize);
+ atomic_add(skb->truesize, &sk->sk_wmem_alloc);
+ }
return skb;
}
--
2.5.5
next reply other threads:[~2017-01-12 5:02 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-12 5:02 Cong Wang [this message]
2017-01-12 5:02 ` [Patch net] atm: switch to the new wait API for vcc_sendmsg() Cong Wang
2017-01-12 8:43 ` [Patch net] atm: remove an unnecessary loop Michal Hocko
2017-01-13 0:07 ` Francois Romieu
2017-01-13 0:14 ` Cong Wang
2017-01-13 13:23 ` Francois Romieu
2017-01-13 18:18 ` Cong Wang
2017-01-14 0:15 ` Francois Romieu
2017-01-14 0:41 ` Cong Wang
2017-01-13 17:10 ` David Miller
2017-01-13 18:20 ` Cong Wang
2017-01-13 23:54 ` Chas Williams
2017-01-14 0:30 ` Cong Wang
2017-01-14 11:34 ` Chas Williams
2017-01-14 0:14 ` Francois Romieu
2017-01-14 0:24 ` Francois Romieu
2017-01-14 0:36 ` Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1484197322-958-1-git-send-email-xiyou.wangcong@gmail.com \
--to=xiyou.wangcong@gmail.com \
--cc=3chas3@gmail.com \
--cc=andreyknvl@google.com \
--cc=mhocko@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).