From: yuan linyu <cugyly@163.com>
To: Florian Fainelli <f.fainelli@gmail.com>, Andrew Lunn <andrew@lunn.ch>
Cc: "David S . Miller" <davem@davemloft.net>,
netdev@vger.kernel.org,
yuan linyu <Linyu.Yuan@alcatel-sbell.com.cn>
Subject: Re: [PATCH] net: add regs attribute to phy device for user diagnose
Date: Sun, 15 Jan 2017 18:40:52 +0800 [thread overview]
Message-ID: <1484476852.7461.4.camel@163.com> (raw)
In-Reply-To: <580590a9-d03b-2fab-efe7-173427b7c331@gmail.com>
On 六, 2017-01-14 at 17:57 -0800, Florian Fainelli wrote:
> Le 01/14/17 à 17:51, yuan linyu a écrit :
> >
> > I think mii-tool or ethtool can't do it currently.
> Maybe they cannot right now but they can certainly be patched to support
> that. sysfs is not an appropriate interface for what you are proposing
> here. We already have a set/get register via ethtool (-d/-D) it would
> seem natural to use this.
I think most ethernet driver implement ethtool -d to dump mac register.
>
> Besides that, are not the current ioctl() good enough for that?
I think user/developer diagnose through simple attribute file will be easy.
next prev parent reply other threads:[~2017-01-15 10:41 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-14 2:46 [PATCH] net: add regs attribute to phy device for user diagnose yuan linyu
2017-01-14 16:24 ` Andrew Lunn
2017-01-14 18:35 ` Florian Fainelli
2017-01-15 1:51 ` yuan linyu
2017-01-15 1:57 ` Florian Fainelli
2017-01-15 10:40 ` yuan linyu [this message]
2017-01-15 17:21 ` Andrew Lunn
2017-01-16 12:59 ` yuan linyu
2017-01-16 20:22 ` Florian Fainelli
2017-01-16 21:54 ` David Miller
2017-01-17 0:11 ` YUAN Linyu
2017-01-18 12:37 ` Zefir Kurtisi
2017-01-19 0:45 ` YUAN Linyu
2017-01-19 1:01 ` Andrew Lunn
2017-02-11 3:48 ` yuan linyu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1484476852.7461.4.camel@163.com \
--to=cugyly@163.com \
--cc=Linyu.Yuan@alcatel-sbell.com.cn \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).