* [PATCH iproute2] tc: flower: Fix flower output for src and dst ports
@ 2017-01-15 14:23 Roi Dayan
2017-01-24 8:42 ` Simon Horman
0 siblings, 1 reply; 2+ messages in thread
From: Roi Dayan @ 2017-01-15 14:23 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: netdev, Simon Horman, Roi Dayan, Paul Blakey
This fix a missing use case after the introduction of enum flower_endpoint.
Fixes: 6910d65661a3 ("tc: flower: introduce enum flower_endpoint")
Signed-off-by: Roi Dayan <roid@mellanox.com>
Signed-off-by: Paul Blakey <paulb@mellanox.com>
---
tc/f_flower.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/tc/f_flower.c b/tc/f_flower.c
index 71e9515..1dbc532 100644
--- a/tc/f_flower.c
+++ b/tc/f_flower.c
@@ -744,10 +744,10 @@ static int flower_print_opt(struct filter_util *qu, FILE *f,
tb[TCA_FLOWER_KEY_IPV6_SRC],
tb[TCA_FLOWER_KEY_IPV6_SRC_MASK]);
- nl_type = flower_port_attr_type(ip_proto, false);
+ nl_type = flower_port_attr_type(ip_proto, FLOWER_ENDPOINT_DST);
if (nl_type >= 0)
flower_print_port(f, "dst_port", tb[nl_type]);
- nl_type = flower_port_attr_type(ip_proto, true);
+ nl_type = flower_port_attr_type(ip_proto, FLOWER_ENDPOINT_SRC);
if (nl_type >= 0)
flower_print_port(f, "src_port", tb[nl_type]);
--
1.7.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH iproute2] tc: flower: Fix flower output for src and dst ports
2017-01-15 14:23 [PATCH iproute2] tc: flower: Fix flower output for src and dst ports Roi Dayan
@ 2017-01-24 8:42 ` Simon Horman
0 siblings, 0 replies; 2+ messages in thread
From: Simon Horman @ 2017-01-24 8:42 UTC (permalink / raw)
To: Roi Dayan; +Cc: Stephen Hemminger, netdev, Paul Blakey
On Sun, Jan 15, 2017 at 04:23:49PM +0200, Roi Dayan wrote:
> This fix a missing use case after the introduction of enum flower_endpoint.
>
> Fixes: 6910d65661a3 ("tc: flower: introduce enum flower_endpoint")
> Signed-off-by: Roi Dayan <roid@mellanox.com>
> Signed-off-by: Paul Blakey <paulb@mellanox.com>
Thanks, sorry for missing that:
Reviewed-by: Simon Horman <simon.horman@netronome.com>
> ---
> tc/f_flower.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tc/f_flower.c b/tc/f_flower.c
> index 71e9515..1dbc532 100644
> --- a/tc/f_flower.c
> +++ b/tc/f_flower.c
> @@ -744,10 +744,10 @@ static int flower_print_opt(struct filter_util *qu, FILE *f,
> tb[TCA_FLOWER_KEY_IPV6_SRC],
> tb[TCA_FLOWER_KEY_IPV6_SRC_MASK]);
>
> - nl_type = flower_port_attr_type(ip_proto, false);
> + nl_type = flower_port_attr_type(ip_proto, FLOWER_ENDPOINT_DST);
> if (nl_type >= 0)
> flower_print_port(f, "dst_port", tb[nl_type]);
> - nl_type = flower_port_attr_type(ip_proto, true);
> + nl_type = flower_port_attr_type(ip_proto, FLOWER_ENDPOINT_SRC);
> if (nl_type >= 0)
> flower_print_port(f, "src_port", tb[nl_type]);
>
> --
> 1.7.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-01-24 8:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-01-15 14:23 [PATCH iproute2] tc: flower: Fix flower output for src and dst ports Roi Dayan
2017-01-24 8:42 ` Simon Horman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).