From: Shyam Saini <mayhs11saini@gmail.com>
To: Yuval.Mintz@cavium.com
Cc: Ariel.Elior@cavium.com, everest-linux-l2@cavium.com,
netdev@vger.kernel.org, Shyam Saini <mayhs11saini@gmail.com>
Subject: [PATCH 1/2] qed: Replace memset with eth_zero_addr
Date: Mon, 16 Jan 2017 09:14:36 +0530 [thread overview]
Message-ID: <1484538277-21376-1-git-send-email-mayhs11saini@gmail.com> (raw)
Use eth_zero_addr to assign zero address to the given address array
instead of memset when the second argument in memset is address
of zero. Also, it makes the code clearer
Signed-off-by: Shyam Saini <mayhs11saini@gmail.com>
---
drivers/net/ethernet/qlogic/qed/qed_l2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/qlogic/qed/qed_l2.c b/drivers/net/ethernet/qlogic/qed/qed_l2.c
index 6a3727c..778c52c 100644
--- a/drivers/net/ethernet/qlogic/qed/qed_l2.c
+++ b/drivers/net/ethernet/qlogic/qed/qed_l2.c
@@ -1776,7 +1776,7 @@ static int qed_fill_eth_dev_info(struct qed_dev *cdev,
qed_fill_dev_info(cdev, &info->common);
if (IS_VF(cdev))
- memset(info->common.hw_mac, 0, ETH_ALEN);
+ eth_zero_addr(info->common.hw_mac);
return 0;
}
--
2.7.4
next reply other threads:[~2017-01-16 3:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-16 3:44 Shyam Saini [this message]
2017-01-16 3:44 ` [PATCH 2/2] qed: Replace memset with eth_zero_addr Shyam Saini
2017-01-16 4:38 ` [PATCH 1/2] " David Miller
2017-01-16 9:24 ` Shyam Saini
2017-01-16 16:46 ` David Miller
2017-01-16 17:05 ` Mintz, Yuval
2017-01-16 17:12 ` David Miller
2017-01-16 17:40 ` Shyam Saini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1484538277-21376-1-git-send-email-mayhs11saini@gmail.com \
--to=mayhs11saini@gmail.com \
--cc=Ariel.Elior@cavium.com \
--cc=Yuval.Mintz@cavium.com \
--cc=everest-linux-l2@cavium.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).