* [PATCH iproute2 net-next 1/5] iplink: bridge: add support for IFLA_BR_FDB_FLUSH
2017-01-17 9:32 [PATCH iproute2 net-next 0/5] add latest bridge netlink options Hangbin Liu
@ 2017-01-17 9:32 ` Hangbin Liu
2017-01-17 10:36 ` Nikolay Aleksandrov
2017-01-17 9:32 ` [PATCH iproute2 net-next 2/5] iplink: bridge: add support for IFLA_BR_VLAN_STATS_ENABLED Hangbin Liu
` (4 subsequent siblings)
5 siblings, 1 reply; 12+ messages in thread
From: Hangbin Liu @ 2017-01-17 9:32 UTC (permalink / raw)
To: netdev; +Cc: Stephen Hemminger, Hangbin Liu
This patch implements support for the IFLA_BR_FDB_FLUSH attribute
in iproute2 so it can flush bridge fdb dynamic entries.
Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
---
ip/iplink_bridge.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/ip/iplink_bridge.c b/ip/iplink_bridge.c
index d2d4202..85e6597 100644
--- a/ip/iplink_bridge.c
+++ b/ip/iplink_bridge.c
@@ -22,7 +22,8 @@
static void print_explain(FILE *f)
{
fprintf(f,
- "Usage: ... bridge [ forward_delay FORWARD_DELAY ]\n"
+ "Usage: ... bridge [ fdb_flush ]\n"
+ " [ forward_delay FORWARD_DELAY ]\n"
" [ hello_time HELLO_TIME ]\n"
" [ max_age MAX_AGE ]\n"
" [ ageing_time AGEING_TIME ]\n"
@@ -145,6 +146,8 @@ static int bridge_parse_opt(struct link_util *lu, int argc, char **argv,
if (len < 0)
return -1;
addattr_l(n, 1024, IFLA_BR_GROUP_ADDR, llabuf, len);
+ } else if (matches(*argv, "fdb_flush") == 0) {
+ addattr(n, 1024, IFLA_BR_FDB_FLUSH);
} else if (matches(*argv, "vlan_default_pvid") == 0) {
__u16 default_pvid;
--
2.5.5
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH iproute2 net-next 2/5] iplink: bridge: add support for IFLA_BR_VLAN_STATS_ENABLED
2017-01-17 9:32 [PATCH iproute2 net-next 0/5] add latest bridge netlink options Hangbin Liu
2017-01-17 9:32 ` [PATCH iproute2 net-next 1/5] iplink: bridge: add support for IFLA_BR_FDB_FLUSH Hangbin Liu
@ 2017-01-17 9:32 ` Hangbin Liu
2017-01-17 9:52 ` Nikolay Aleksandrov
2017-01-17 9:32 ` [PATCH iproute2 net-next 3/5] iplink: bridge: add support for IFLA_BR_MCAST_STATS_ENABLED Hangbin Liu
` (3 subsequent siblings)
5 siblings, 1 reply; 12+ messages in thread
From: Hangbin Liu @ 2017-01-17 9:32 UTC (permalink / raw)
To: netdev; +Cc: Stephen Hemminger, Hangbin Liu
This patch implements support for the IFLA_BR_VLAN_STATS_ENABLED
attribute in iproute2 so it can change the vlan state.
Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
---
ip/iplink_bridge.c | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/ip/iplink_bridge.c b/ip/iplink_bridge.c
index 85e6597..8caf53a 100644
--- a/ip/iplink_bridge.c
+++ b/ip/iplink_bridge.c
@@ -34,6 +34,7 @@ static void print_explain(FILE *f)
" [ vlan_filtering VLAN_FILTERING ]\n"
" [ vlan_protocol VLAN_PROTOCOL ]\n"
" [ vlan_default_pvid VLAN_DEFAULT_PVID ]\n"
+ " [ vlan_state VLAN_STATE ]\n"
" [ mcast_snooping MULTICAST_SNOOPING ]\n"
" [ mcast_router MULTICAST_ROUTER ]\n"
" [ mcast_query_use_ifaddr MCAST_QUERY_USE_IFADDR ]\n"
@@ -157,6 +158,14 @@ static int bridge_parse_opt(struct link_util *lu, int argc, char **argv,
addattr16(n, 1024, IFLA_BR_VLAN_DEFAULT_PVID,
default_pvid);
+ } else if (matches(*argv, "vlan_state") == 0) {
+ __u8 vlan_state;
+
+ NEXT_ARG();
+ if (get_u8(&vlan_state, *argv, 0))
+ invarg("invalid vlan_state", *argv);
+ addattr8(n, 1024, IFLA_BR_VLAN_STATS_ENABLED,
+ vlan_state);
} else if (matches(*argv, "mcast_router") == 0) {
__u8 mcast_router;
@@ -442,6 +451,10 @@ static void bridge_print_opt(struct link_util *lu, FILE *f, struct rtattr *tb[])
fprintf(f, "vlan_default_pvid %u ",
rta_getattr_u16(tb[IFLA_BR_VLAN_DEFAULT_PVID]));
+ if (tb[IFLA_BR_VLAN_STATS_ENABLED])
+ fprintf(f, "vlan_state %u ",
+ rta_getattr_u8(tb[IFLA_BR_VLAN_STATS_ENABLED]));
+
if (tb[IFLA_BR_GROUP_FWD_MASK])
fprintf(f, "group_fwd_mask %#x ",
rta_getattr_u16(tb[IFLA_BR_GROUP_FWD_MASK]));
--
2.5.5
^ permalink raw reply related [flat|nested] 12+ messages in thread* Re: [PATCH iproute2 net-next 2/5] iplink: bridge: add support for IFLA_BR_VLAN_STATS_ENABLED
2017-01-17 9:32 ` [PATCH iproute2 net-next 2/5] iplink: bridge: add support for IFLA_BR_VLAN_STATS_ENABLED Hangbin Liu
@ 2017-01-17 9:52 ` Nikolay Aleksandrov
0 siblings, 0 replies; 12+ messages in thread
From: Nikolay Aleksandrov @ 2017-01-17 9:52 UTC (permalink / raw)
To: Hangbin Liu, netdev; +Cc: Stephen Hemminger
On 17/01/17 10:32, Hangbin Liu wrote:
> This patch implements support for the IFLA_BR_VLAN_STATS_ENABLED
> attribute in iproute2 so it can change the vlan state.
>
> Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
> ---
Again it is not state, it is _stats_. Please change the name to something like vlan_stats_enabled which is closer to the netlink attribute.
> ip/iplink_bridge.c | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/ip/iplink_bridge.c b/ip/iplink_bridge.c
> index 85e6597..8caf53a 100644
> --- a/ip/iplink_bridge.c
> +++ b/ip/iplink_bridge.c
> @@ -34,6 +34,7 @@ static void print_explain(FILE *f)
> " [ vlan_filtering VLAN_FILTERING ]\n"
> " [ vlan_protocol VLAN_PROTOCOL ]\n"
> " [ vlan_default_pvid VLAN_DEFAULT_PVID ]\n"
> + " [ vlan_state VLAN_STATE ]\n"
> " [ mcast_snooping MULTICAST_SNOOPING ]\n"
> " [ mcast_router MULTICAST_ROUTER ]\n"
> " [ mcast_query_use_ifaddr MCAST_QUERY_USE_IFADDR ]\n"
> @@ -157,6 +158,14 @@ static int bridge_parse_opt(struct link_util *lu, int argc, char **argv,
>
> addattr16(n, 1024, IFLA_BR_VLAN_DEFAULT_PVID,
> default_pvid);
> + } else if (matches(*argv, "vlan_state") == 0) {
> + __u8 vlan_state;
> +
> + NEXT_ARG();
> + if (get_u8(&vlan_state, *argv, 0))
> + invarg("invalid vlan_state", *argv);
> + addattr8(n, 1024, IFLA_BR_VLAN_STATS_ENABLED,
> + vlan_state);
> } else if (matches(*argv, "mcast_router") == 0) {
> __u8 mcast_router;
>
> @@ -442,6 +451,10 @@ static void bridge_print_opt(struct link_util *lu, FILE *f, struct rtattr *tb[])
> fprintf(f, "vlan_default_pvid %u ",
> rta_getattr_u16(tb[IFLA_BR_VLAN_DEFAULT_PVID]));
>
> + if (tb[IFLA_BR_VLAN_STATS_ENABLED])
> + fprintf(f, "vlan_state %u ",
> + rta_getattr_u8(tb[IFLA_BR_VLAN_STATS_ENABLED]));
> +
> if (tb[IFLA_BR_GROUP_FWD_MASK])
> fprintf(f, "group_fwd_mask %#x ",
> rta_getattr_u16(tb[IFLA_BR_GROUP_FWD_MASK]));
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH iproute2 net-next 3/5] iplink: bridge: add support for IFLA_BR_MCAST_STATS_ENABLED
2017-01-17 9:32 [PATCH iproute2 net-next 0/5] add latest bridge netlink options Hangbin Liu
2017-01-17 9:32 ` [PATCH iproute2 net-next 1/5] iplink: bridge: add support for IFLA_BR_FDB_FLUSH Hangbin Liu
2017-01-17 9:32 ` [PATCH iproute2 net-next 2/5] iplink: bridge: add support for IFLA_BR_VLAN_STATS_ENABLED Hangbin Liu
@ 2017-01-17 9:32 ` Hangbin Liu
2017-01-17 9:51 ` Nikolay Aleksandrov
2017-01-17 9:32 ` [PATCH iproute2 net-next 4/5] iplink: bridge: add support for IFLA_BR_MCAST_IGMP_VERSION Hangbin Liu
` (2 subsequent siblings)
5 siblings, 1 reply; 12+ messages in thread
From: Hangbin Liu @ 2017-01-17 9:32 UTC (permalink / raw)
To: netdev; +Cc: Stephen Hemminger, Hangbin Liu
This patch implements support for the IFLA_BR_MCAST_STATS_ENABLED
attribute in iproute2 so it can change the mcast state.
Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
---
ip/iplink_bridge.c | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/ip/iplink_bridge.c b/ip/iplink_bridge.c
index 8caf53a..622bd07 100644
--- a/ip/iplink_bridge.c
+++ b/ip/iplink_bridge.c
@@ -49,6 +49,7 @@ static void print_explain(FILE *f)
" [ mcast_query_interval QUERY_INTERVAL ]\n"
" [ mcast_query_response_interval QUERY_RESPONSE_INTERVAL ]\n"
" [ mcast_startup_query_interval STARTUP_QUERY_INTERVAL ]\n"
+ " [ mcast_state MCAST_STATE ]\n"
" [ nf_call_iptables NF_CALL_IPTABLES ]\n"
" [ nf_call_ip6tables NF_CALL_IP6TABLES ]\n"
" [ nf_call_arptables NF_CALL_ARPTABLES ]\n"
@@ -299,6 +300,14 @@ static int bridge_parse_opt(struct link_util *lu, int argc, char **argv,
addattr64(n, 1024, IFLA_BR_MCAST_STARTUP_QUERY_INTVL,
mcast_startup_query_intvl);
+ } else if (matches(*argv, "mcast_state") == 0) {
+ __u8 mcast_state;
+
+ NEXT_ARG();
+ if (get_u8(&mcast_state, *argv, 0))
+ invarg("invalid mcast_state", *argv);
+ addattr8(n, 1024, IFLA_BR_MCAST_STATS_ENABLED,
+ mcast_state);
} else if (matches(*argv, "nf_call_iptables") == 0) {
__u8 nf_call_ipt;
@@ -524,6 +533,10 @@ static void bridge_print_opt(struct link_util *lu, FILE *f, struct rtattr *tb[])
fprintf(f, "mcast_startup_query_interval %llu ",
rta_getattr_u64(tb[IFLA_BR_MCAST_STARTUP_QUERY_INTVL]));
+ if (tb[IFLA_BR_MCAST_STATS_ENABLED])
+ fprintf(f, "mcast_state %u ",
+ rta_getattr_u8(tb[IFLA_BR_MCAST_STATS_ENABLED]));
+
if (tb[IFLA_BR_NF_CALL_IPTABLES])
fprintf(f, "nf_call_iptables %u ",
rta_getattr_u8(tb[IFLA_BR_NF_CALL_IPTABLES]));
--
2.5.5
^ permalink raw reply related [flat|nested] 12+ messages in thread* Re: [PATCH iproute2 net-next 3/5] iplink: bridge: add support for IFLA_BR_MCAST_STATS_ENABLED
2017-01-17 9:32 ` [PATCH iproute2 net-next 3/5] iplink: bridge: add support for IFLA_BR_MCAST_STATS_ENABLED Hangbin Liu
@ 2017-01-17 9:51 ` Nikolay Aleksandrov
0 siblings, 0 replies; 12+ messages in thread
From: Nikolay Aleksandrov @ 2017-01-17 9:51 UTC (permalink / raw)
To: Hangbin Liu, netdev; +Cc: Stephen Hemminger
On 17/01/17 10:32, Hangbin Liu wrote:
> This patch implements support for the IFLA_BR_MCAST_STATS_ENABLED
> attribute in iproute2 so it can change the mcast state.
>
> Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
> ---
It is not state, it is _stats_. Calling it mcast_state is completely wrong, please
change the name to something like mcast_stats_enabled which is closer to the sysfs
and netlink attribute.
> ip/iplink_bridge.c | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/ip/iplink_bridge.c b/ip/iplink_bridge.c
> index 8caf53a..622bd07 100644
> --- a/ip/iplink_bridge.c
> +++ b/ip/iplink_bridge.c
> @@ -49,6 +49,7 @@ static void print_explain(FILE *f)
> " [ mcast_query_interval QUERY_INTERVAL ]\n"
> " [ mcast_query_response_interval QUERY_RESPONSE_INTERVAL ]\n"
> " [ mcast_startup_query_interval STARTUP_QUERY_INTERVAL ]\n"
> + " [ mcast_state MCAST_STATE ]\n"
> " [ nf_call_iptables NF_CALL_IPTABLES ]\n"
> " [ nf_call_ip6tables NF_CALL_IP6TABLES ]\n"
> " [ nf_call_arptables NF_CALL_ARPTABLES ]\n"
> @@ -299,6 +300,14 @@ static int bridge_parse_opt(struct link_util *lu, int argc, char **argv,
>
> addattr64(n, 1024, IFLA_BR_MCAST_STARTUP_QUERY_INTVL,
> mcast_startup_query_intvl);
> + } else if (matches(*argv, "mcast_state") == 0) {
> + __u8 mcast_state;
> +
> + NEXT_ARG();
> + if (get_u8(&mcast_state, *argv, 0))
> + invarg("invalid mcast_state", *argv);
> + addattr8(n, 1024, IFLA_BR_MCAST_STATS_ENABLED,
> + mcast_state);
> } else if (matches(*argv, "nf_call_iptables") == 0) {
> __u8 nf_call_ipt;
>
> @@ -524,6 +533,10 @@ static void bridge_print_opt(struct link_util *lu, FILE *f, struct rtattr *tb[])
> fprintf(f, "mcast_startup_query_interval %llu ",
> rta_getattr_u64(tb[IFLA_BR_MCAST_STARTUP_QUERY_INTVL]));
>
> + if (tb[IFLA_BR_MCAST_STATS_ENABLED])
> + fprintf(f, "mcast_state %u ",
> + rta_getattr_u8(tb[IFLA_BR_MCAST_STATS_ENABLED]));
> +
> if (tb[IFLA_BR_NF_CALL_IPTABLES])
> fprintf(f, "nf_call_iptables %u ",
> rta_getattr_u8(tb[IFLA_BR_NF_CALL_IPTABLES]));
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH iproute2 net-next 4/5] iplink: bridge: add support for IFLA_BR_MCAST_IGMP_VERSION
2017-01-17 9:32 [PATCH iproute2 net-next 0/5] add latest bridge netlink options Hangbin Liu
` (2 preceding siblings ...)
2017-01-17 9:32 ` [PATCH iproute2 net-next 3/5] iplink: bridge: add support for IFLA_BR_MCAST_STATS_ENABLED Hangbin Liu
@ 2017-01-17 9:32 ` Hangbin Liu
2017-01-17 10:34 ` Nikolay Aleksandrov
2017-01-17 9:32 ` [PATCH iproute2 net-next 5/5] iplink: bridge: add support for IFLA_BR_MCAST_MLD_VERSION Hangbin Liu
2017-01-17 10:03 ` [PATCH iproute2 net-next 0/5] add latest bridge netlink options Nikolay Aleksandrov
5 siblings, 1 reply; 12+ messages in thread
From: Hangbin Liu @ 2017-01-17 9:32 UTC (permalink / raw)
To: netdev; +Cc: Stephen Hemminger, Hangbin Liu
This patch implements support for the IFLA_BR_MCAST_IGMP_VERSION
attribute in iproute2 so it can change the mcast igmp version.
Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
---
ip/iplink_bridge.c | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/ip/iplink_bridge.c b/ip/iplink_bridge.c
index 622bd07..6611a85 100644
--- a/ip/iplink_bridge.c
+++ b/ip/iplink_bridge.c
@@ -50,6 +50,7 @@ static void print_explain(FILE *f)
" [ mcast_query_response_interval QUERY_RESPONSE_INTERVAL ]\n"
" [ mcast_startup_query_interval STARTUP_QUERY_INTERVAL ]\n"
" [ mcast_state MCAST_STATE ]\n"
+ " [ mcast_igmp_version IGMP_VERSION ]\n"
" [ nf_call_iptables NF_CALL_IPTABLES ]\n"
" [ nf_call_ip6tables NF_CALL_IP6TABLES ]\n"
" [ nf_call_arptables NF_CALL_ARPTABLES ]\n"
@@ -308,6 +309,14 @@ static int bridge_parse_opt(struct link_util *lu, int argc, char **argv,
invarg("invalid mcast_state", *argv);
addattr8(n, 1024, IFLA_BR_MCAST_STATS_ENABLED,
mcast_state);
+ } else if (matches(*argv, "mcast_igmp_version") == 0) {
+ __u8 igmp_version;
+
+ NEXT_ARG();
+ if (get_u8(&igmp_version, *argv, 0))
+ invarg("invalid mcast_igmp_version", *argv);
+ addattr8(n, 1024, IFLA_BR_MCAST_IGMP_VERSION,
+ igmp_version);
} else if (matches(*argv, "nf_call_iptables") == 0) {
__u8 nf_call_ipt;
@@ -537,6 +546,10 @@ static void bridge_print_opt(struct link_util *lu, FILE *f, struct rtattr *tb[])
fprintf(f, "mcast_state %u ",
rta_getattr_u8(tb[IFLA_BR_MCAST_STATS_ENABLED]));
+ if (tb[IFLA_BR_MCAST_IGMP_VERSION])
+ fprintf(f, "mcast_igmp_version %u ",
+ rta_getattr_u8(tb[IFLA_BR_MCAST_IGMP_VERSION]));
+
if (tb[IFLA_BR_NF_CALL_IPTABLES])
fprintf(f, "nf_call_iptables %u ",
rta_getattr_u8(tb[IFLA_BR_NF_CALL_IPTABLES]));
--
2.5.5
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH iproute2 net-next 5/5] iplink: bridge: add support for IFLA_BR_MCAST_MLD_VERSION
2017-01-17 9:32 [PATCH iproute2 net-next 0/5] add latest bridge netlink options Hangbin Liu
` (3 preceding siblings ...)
2017-01-17 9:32 ` [PATCH iproute2 net-next 4/5] iplink: bridge: add support for IFLA_BR_MCAST_IGMP_VERSION Hangbin Liu
@ 2017-01-17 9:32 ` Hangbin Liu
2017-01-17 10:35 ` Nikolay Aleksandrov
2017-01-17 10:03 ` [PATCH iproute2 net-next 0/5] add latest bridge netlink options Nikolay Aleksandrov
5 siblings, 1 reply; 12+ messages in thread
From: Hangbin Liu @ 2017-01-17 9:32 UTC (permalink / raw)
To: netdev; +Cc: Stephen Hemminger, Hangbin Liu
This patch implements support for the IFLA_BR_MCAST_MLD_VERSION
attribute in iproute2 so it can change the mcast mld version.
Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
---
ip/iplink_bridge.c | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/ip/iplink_bridge.c b/ip/iplink_bridge.c
index 6611a85..f484d05 100644
--- a/ip/iplink_bridge.c
+++ b/ip/iplink_bridge.c
@@ -51,6 +51,7 @@ static void print_explain(FILE *f)
" [ mcast_startup_query_interval STARTUP_QUERY_INTERVAL ]\n"
" [ mcast_state MCAST_STATE ]\n"
" [ mcast_igmp_version IGMP_VERSION ]\n"
+ " [ mcast_mld_version MLD_VERSION ]\n"
" [ nf_call_iptables NF_CALL_IPTABLES ]\n"
" [ nf_call_ip6tables NF_CALL_IP6TABLES ]\n"
" [ nf_call_arptables NF_CALL_ARPTABLES ]\n"
@@ -317,6 +318,14 @@ static int bridge_parse_opt(struct link_util *lu, int argc, char **argv,
invarg("invalid mcast_igmp_version", *argv);
addattr8(n, 1024, IFLA_BR_MCAST_IGMP_VERSION,
igmp_version);
+ } else if (matches(*argv, "mcast_mld_version") == 0) {
+ __u8 mld_version;
+
+ NEXT_ARG();
+ if (get_u8(&mld_version, *argv, 0))
+ invarg("invalid mcast_mld_version", *argv);
+ addattr8(n, 1024, IFLA_BR_MCAST_MLD_VERSION,
+ mld_version);
} else if (matches(*argv, "nf_call_iptables") == 0) {
__u8 nf_call_ipt;
@@ -550,6 +559,10 @@ static void bridge_print_opt(struct link_util *lu, FILE *f, struct rtattr *tb[])
fprintf(f, "mcast_igmp_version %u ",
rta_getattr_u8(tb[IFLA_BR_MCAST_IGMP_VERSION]));
+ if (tb[IFLA_BR_MCAST_MLD_VERSION])
+ fprintf(f, "mcast_mld_version %u ",
+ rta_getattr_u8(tb[IFLA_BR_MCAST_MLD_VERSION]));
+
if (tb[IFLA_BR_NF_CALL_IPTABLES])
fprintf(f, "nf_call_iptables %u ",
rta_getattr_u8(tb[IFLA_BR_NF_CALL_IPTABLES]));
--
2.5.5
^ permalink raw reply related [flat|nested] 12+ messages in thread* Re: [PATCH iproute2 net-next 0/5] add latest bridge netlink options
2017-01-17 9:32 [PATCH iproute2 net-next 0/5] add latest bridge netlink options Hangbin Liu
` (4 preceding siblings ...)
2017-01-17 9:32 ` [PATCH iproute2 net-next 5/5] iplink: bridge: add support for IFLA_BR_MCAST_MLD_VERSION Hangbin Liu
@ 2017-01-17 10:03 ` Nikolay Aleksandrov
5 siblings, 0 replies; 12+ messages in thread
From: Nikolay Aleksandrov @ 2017-01-17 10:03 UTC (permalink / raw)
To: Hangbin Liu, netdev; +Cc: Stephen Hemminger
On 17/01/17 10:32, Hangbin Liu wrote:
> Add the bridge netlink attributes added to kernel recently.
>
> Hangbin Liu (5):
> iplink: bridge: add support for IFLA_BR_FDB_FLUSH
> iplink: bridge: add support for IFLA_BR_VLAN_STATS_ENABLED
> iplink: bridge: add support for IFLA_BR_MCAST_STATS_ENABLED
> iplink: bridge: add support for IFLA_BR_MCAST_IGMP_VERSION
> iplink: bridge: add support for IFLA_BR_MCAST_MLD_VERSION
>
> ip/iplink_bridge.c | 57 +++++++++++++++++++++++++++++++++++++++++++++++++++++-
> 1 file changed, 56 insertions(+), 1 deletion(-)
>
Cool, I also have a version of all of these patches just didn't get around to send them yet. :-)
Anyway since you're at it, you should also add support for IFLA_BRPORT_FLUSH,
but TBH I don't think the flush attributes should be used via this command, they seem
like an action that you do rather than an option that you set. That is the reason I
didn't add support for them awhile back when I added the others. But I don't have a
strong feeling about doing it via ip link set or not, so if the others are fine, I'm good too.
Cheers,
Nik
^ permalink raw reply [flat|nested] 12+ messages in thread