netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Volodymyr Bendiuga <volodymyr.bendiuga@gmail.com>
To: f.fainelli@gmail.com, andrew@lunn.ch, netdev@vger.kernel.org,
	volodymyr.bendiuga@westermo.se
Cc: "Volodymyr Bendiuga" <volodymyr.bendiuga@gmail.com>,
	"Magnus Öberg" <magnus.oberg@westermo.se>
Subject: [PATCH v3 net-next] phy: increase size of MII_BUS_ID_SIZE and bus_id
Date: Thu, 19 Jan 2017 17:05:04 +0100	[thread overview]
Message-ID: <1484841904-19313-1-git-send-email-volodymyr.bendiuga@gmail.com> (raw)

Some bus names are pretty long and do not fit into
17 chars. Increase therefore MII_BUS_ID_SIZE and
phy_fixup.bus_id to larger number. Now mii_bus.id
can host larger name.

Signed-off-by: Volodymyr Bendiuga <volodymyr.bendiuga@gmail.com>
Signed-off-by: Magnus Öberg <magnus.oberg@westermo.se>
---
 include/linux/phy.h | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/include/linux/phy.h b/include/linux/phy.h
index f7d95f6..5c9d252 100644
--- a/include/linux/phy.h
+++ b/include/linux/phy.h
@@ -158,11 +158,7 @@ static inline const char *phy_modes(phy_interface_t interface)
 /* Used when trying to connect to a specific phy (mii bus id:phy device id) */
 #define PHY_ID_FMT "%s:%02x"
 
-/*
- * Need to be a little smaller than phydev->dev.bus_id to leave room
- * for the ":%02x"
- */
-#define MII_BUS_ID_SIZE	(20 - 3)
+#define MII_BUS_ID_SIZE	61
 
 /* Or MII_ADDR_C45 into regnum for read/write on mii_bus to enable the 21 bit
    IEEE 802.3ae clause 45 addressing mode used by 10GIGE phy chips. */
@@ -632,7 +628,7 @@ struct phy_driver {
 /* A Structure for boards to register fixups with the PHY Lib */
 struct phy_fixup {
 	struct list_head list;
-	char bus_id[20];
+	char bus_id[MII_BUS_ID_SIZE + 3];
 	u32 phy_uid;
 	u32 phy_uid_mask;
 	int (*run)(struct phy_device *phydev);
-- 
2.7.4

             reply	other threads:[~2017-01-19 16:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-19 16:05 Volodymyr Bendiuga [this message]
2017-01-19 16:40 ` [PATCH v3 net-next] phy: increase size of MII_BUS_ID_SIZE and bus_id Andrew Lunn
2017-01-19 16:52 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1484841904-19313-1-git-send-email-volodymyr.bendiuga@gmail.com \
    --to=volodymyr.bendiuga@gmail.com \
    --cc=andrew@lunn.ch \
    --cc=f.fainelli@gmail.com \
    --cc=magnus.oberg@westermo.se \
    --cc=netdev@vger.kernel.org \
    --cc=volodymyr.bendiuga@westermo.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).