From: Johannes Berg <johannes@sipsolutions.net>
To: "Amadeusz Sławiński" <amadeusz.slawinski@tieto.com>,
linux-wireless@vger.kernel.org
Cc: "David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] mac80211: use accessor functions to set sta->_flags
Date: Tue, 24 Jan 2017 16:44:28 +0100 [thread overview]
Message-ID: <1485272668.1236.5.camel@sipsolutions.net> (raw)
In-Reply-To: <1485272531-11587-2-git-send-email-amadeusz.slawinski@tieto.com> (sfid-20170124_164229_076986_6C281934)
On Tue, 2017-01-24 at 16:42 +0100, Amadeusz Sławiński wrote:
> cleanup patch to make use of set_sta_flag()/clear_sta_flag() in
> places
> where we access sta->_flags
>
> Signed-off-by: Amadeusz Sławiński <amadeusz.slawinski@tieto.com>
> ---
> net/mac80211/sta_info.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/net/mac80211/sta_info.c b/net/mac80211/sta_info.c
> index b6cfcf0..6c9cc2f 100644
> --- a/net/mac80211/sta_info.c
> +++ b/net/mac80211/sta_info.c
> @@ -1855,13 +1855,13 @@ int sta_info_move_state(struct sta_info *sta,
> switch (new_state) {
> case IEEE80211_STA_NONE:
> if (sta->sta_state == IEEE80211_STA_AUTH)
> - clear_bit(WLAN_STA_AUTH, &sta->_flags);
> + clear_sta_flag(sta, WLAN_STA_AUTH);
You should try to run this patch sometime :)
johannes
next prev parent reply other threads:[~2017-01-24 15:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-24 15:42 [PATCH 1/2] mac80211: use helper function to access ieee802_1d_to_ac[] Amadeusz Sławiński
2017-01-24 15:42 ` [PATCH 2/2] mac80211: use accessor functions to set sta->_flags Amadeusz Sławiński
2017-01-24 15:44 ` Johannes Berg [this message]
2017-01-25 8:55 ` Amadeusz Slawinski
[not found] ` <CA+db6Z1OtO4_93KN-YoEaVg79zY5BgX2u0S+8FGVdkWav0iB2g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-01-25 9:17 ` Johannes Berg
2017-01-29 13:45 ` [mac80211] 4a6736b0fd: WARNING:at_net/mac80211/sta_info.h:#sta_info_move_state[mac80211] kernel test robot
2017-01-26 8:51 ` [PATCH 1/2] mac80211: use helper function to access ieee802_1d_to_ac[] Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1485272668.1236.5.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=amadeusz.slawinski@tieto.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).