Netdev List
 help / color / mirror / Atom feed
From: Pavel Belous <pavel.s.belous@gmail.com>
To: tremyfr@gmail.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] net: aquantia: atlantic: use new api ethtool_{get|set}_link_ksettings
Date: Mon, 30 Jan 2017 19:13:02 +0300	[thread overview]
Message-ID: <1485792782-5634-1-git-send-email-pavel.s.belous@gmail.com> (raw)
In-Reply-To: <1485610661-21099-1-git-send-email-tremyfr@gmail.com>

Hi Philippe,

thanks you for your patch, it looks good.
One improvement - could you please add support/advertising for TP?

>+	supported |= SUPPORTED_Autoneg;
need:
	supported |= SUPPORTED_TP;


>+	advertising = (self->aq_nic_cfg.is_autoneg) ?
> 							ADVERTISED_Autoneg : 0U;

need:
	advertising |= ADVERTISED_TP;


Thank you.

  reply	other threads:[~2017-01-30 16:23 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-28 13:37 [PATCH] net: aquantia: atlantic: use new api ethtool_{get|set}_link_ksettings Philippe Reynes
2017-01-30 16:13 ` Pavel Belous [this message]
2017-01-30 21:26   ` Philippe Reynes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1485792782-5634-1-git-send-email-pavel.s.belous@gmail.com \
    --to=pavel.s.belous@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=tremyfr@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox