From: Shannon Nelson <shannon.nelson@oracle.com>
To: netdev@vger.kernel.org, davem@davemloft.net
Cc: sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org,
Shannon Nelson <shannon.nelson@oracle.com>
Subject: [PATCH net-next 5/9] sunvnet: add memory barrier before check for tx enable
Date: Fri, 3 Feb 2017 09:42:31 -0800 [thread overview]
Message-ID: <1486143755-192532-6-git-send-email-shannon.nelson@oracle.com> (raw)
In-Reply-To: <1486143755-192532-1-git-send-email-shannon.nelson@oracle.com>
In order to allow the underlying LDC and outstanding memory operations
to potentially catch up with the driver's Tx requests, add a memory
barrier before checking again for available tx descriptors.
Signed-off-by: Shannon Nelson <shannon.nelson@oracle.com>
---
drivers/net/ethernet/sun/sunvnet_common.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/net/ethernet/sun/sunvnet_common.c b/drivers/net/ethernet/sun/sunvnet_common.c
index 5d0d386..98e758e 100644
--- a/drivers/net/ethernet/sun/sunvnet_common.c
+++ b/drivers/net/ethernet/sun/sunvnet_common.c
@@ -1467,6 +1467,7 @@ ldc_start_done:
dr->prod = (dr->prod + 1) & (VNET_TX_RING_SIZE - 1);
if (unlikely(vnet_tx_dring_avail(dr) < 1)) {
netif_tx_stop_queue(txq);
+ dma_wmb();
if (vnet_tx_dring_avail(dr) > VNET_TX_WAKEUP_THRESH(dr))
netif_tx_wake_queue(txq);
}
--
1.7.1
next prev parent reply other threads:[~2017-02-03 17:42 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-03 17:42 [PATCH net-next 0/9] sunvnet driver updates Shannon Nelson
2017-02-03 17:42 ` [PATCH net-next 1/9] sunvnet: make sunvnet common code dynamically loadable Shannon Nelson
2017-02-03 17:42 ` [PATCH net-next 2/9] sunvnet: remove unused variable in maybe_tx_wakeup Shannon Nelson
2017-02-03 17:42 ` [PATCH net-next 3/9] sunvnet: update version and version printing Shannon Nelson
2017-02-03 17:42 ` [PATCH net-next 4/9] sunvnet: add driver stats for ethtool support Shannon Nelson
2017-02-03 17:42 ` Shannon Nelson [this message]
2017-02-03 17:56 ` [PATCH net-next 5/9] sunvnet: add memory barrier before check for tx enable Eric Dumazet
2017-02-03 21:20 ` Shannon Nelson
2017-02-03 21:52 ` David Miller
2017-02-03 22:11 ` Eric Dumazet
2017-02-04 22:39 ` Shannon Nelson
2017-02-03 17:42 ` [PATCH net-next 6/9] sunvnet: straighten up message event handling logic Shannon Nelson
2017-02-03 17:42 ` [PATCH net-next 7/9] sunvnet: remove extra rcu_read_unlocks Shannon Nelson
2017-02-03 17:42 ` [PATCH net-next 8/9] ldmvsw: update and simplify version string Shannon Nelson
2017-02-03 17:42 ` [PATCH net-next 9/9] ldmvsw: disable tso and gso for bridge operations Shannon Nelson
2017-02-03 17:59 ` Eric Dumazet
2017-02-03 21:21 ` Shannon Nelson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1486143755-192532-6-git-send-email-shannon.nelson@oracle.com \
--to=shannon.nelson@oracle.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).