From: Joe Perches <joe@perches.com>
To: Shannon Nelson <shannon.nelson@oracle.com>,
netdev@vger.kernel.org, davem@davemloft.net
Cc: sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 net-next 5/8] sunvnet: straighten up message event handling logic
Date: Mon, 13 Feb 2017 11:06:42 -0800 [thread overview]
Message-ID: <1487012802.6214.3.camel@perches.com> (raw)
In-Reply-To: <1487012224-403399-6-git-send-email-shannon.nelson@oracle.com>
On Mon, 2017-02-13 at 10:57 -0800, Shannon Nelson wrote:
> The use of gotos for handling the incoming events made this code
> harder to read and support than it should be. This patch straightens
> out and clears up the logic.
>
> Signed-off-by: Shannon Nelson <shannon.nelson@oracle.com>
> ---
> drivers/net/ethernet/sun/sunvnet_common.c | 94 ++++++++++++++---------------
> 1 files changed, 45 insertions(+), 49 deletions(-)
>
> diff --git a/drivers/net/ethernet/sun/sunvnet_common.c b/drivers/net/ethernet/sun/sunvnet_common.c
[]
> @@ -738,41 +738,37 @@ static int vnet_event_napi(struct vnet_port *port, int budget)
[]
> + /* we don't expect any other bits */
> + BUG_ON(port->rx_event & ~(LDC_EVENT_DATA_READY |
> + LDC_EVENT_RESET |
> + LDC_EVENT_UP));
Is it really necessary to use BUG_ON here?
next prev parent reply other threads:[~2017-02-13 19:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-13 18:56 [PATCH v4 net-next 0/8] sunvnet driver updates Shannon Nelson
2017-02-13 18:56 ` [PATCH v4 net-next 1/8] sunvnet: make sunvnet common code dynamically loadable Shannon Nelson
2017-02-13 18:56 ` [PATCH v4 net-next 2/8] sunvnet: remove unused variable in maybe_tx_wakeup Shannon Nelson
2017-02-13 18:56 ` [PATCH v4 net-next 3/8] sunvnet: update version and version printing Shannon Nelson
2017-02-13 18:57 ` [PATCH v4 net-next 4/8] sunvnet: add memory barrier before check for tx enable Shannon Nelson
2017-02-13 18:57 ` [PATCH v4 net-next 5/8] sunvnet: straighten up message event handling logic Shannon Nelson
2017-02-13 19:06 ` Joe Perches [this message]
2017-02-13 19:18 ` Shannon Nelson
2017-02-13 18:57 ` [PATCH v4 net-next 6/8] sunvnet: remove extra rcu_read_unlocks Shannon Nelson
2017-02-13 18:57 ` [PATCH v4 net-next 7/8] ldmvsw: update and simplify version string Shannon Nelson
2017-02-13 18:57 ` [PATCH v4 net-next 8/8] ldmvsw: disable tso and gso for bridge operations Shannon Nelson
2017-02-14 18:04 ` [PATCH v4 net-next 0/8] sunvnet driver updates David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1487012802.6214.3.camel@perches.com \
--to=joe@perches.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=shannon.nelson@oracle.com \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).