From: Joe Perches <joe@perches.com>
To: Tobias Klauser <tklauser@distanz.ch>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] net: hip04: Omit private ndo_get_stats function
Date: Wed, 15 Feb 2017 02:51:21 -0800 [thread overview]
Message-ID: <1487155881.6214.54.camel@perches.com> (raw)
In-Reply-To: <20170215103858.GA27277@distanz.ch>
On Wed, 2017-02-15 at 11:38 +0100, Tobias Klauser wrote:
> On 2017-02-15 at 11:28:08 +0100, Joe Perches <joe@perches.com> wrote:
> > On Tue, 2017-02-14 at 15:10 +0100, Tobias Klauser wrote:
> > > hip04_get_stats() just returns dev->stats so we can leave it
> > > out altogether and let dev_get_stats() do the job.
> >
> > This could be done for at least a few more drivers:
> >
> > drivers/net/ethernet/chelsio/cxgb/sge.c
>
> I don't see an .ndo_get_stats being defined/set in this file. AFAICT,
> this driver sets .ndo_get_stats to t1_get_stats(), which does some
> additional extraction of statistics from device registers and thus
> shouldn't be removed.
Right.
> > drivers/net/ethernet/intel/e1000/e1000_main.c
> > drivers/net/ethernet/intel/ixgb/ixgb_main.c
>
> Will cover these in follow-up patches, thanks.
Thanks.
> > drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c
>
> A patch for pch_gbe already landed in net-next.
Great, cheers, Joe
prev parent reply other threads:[~2017-02-15 10:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-14 14:10 [PATCH] net: hip04: Omit private ndo_get_stats function Tobias Klauser
2017-02-14 20:03 ` David Miller
2017-02-15 10:28 ` Joe Perches
2017-02-15 10:38 ` Tobias Klauser
2017-02-15 10:51 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1487155881.6214.54.camel@perches.com \
--to=joe@perches.com \
--cc=netdev@vger.kernel.org \
--cc=tklauser@distanz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox