* [PATCH 3/3] mwifiex: wake system up when receives a wake irq [not found] <1487917471-5501-1-git-send-email-jeffy.chen@rock-chips.com> @ 2017-02-24 6:24 ` Jeffy Chen 2017-02-24 11:01 ` Kalle Valo 2017-03-20 16:44 ` [3/3] " Kalle Valo 0 siblings, 2 replies; 4+ messages in thread From: Jeffy Chen @ 2017-02-24 6:24 UTC (permalink / raw) To: Amitkumar Karwar Cc: Brian Norris, Rajat Jain, Jeffy Chen, Kalle Valo, netdev, linux-wireless, linux-kernel, Nishant Sarmukadam Currrently we are disabling this wake irq after receiving it. If this happens before we finish suspend and the pm event check is disabled, the system will continue suspending, and this irq would not work again. We may need to abort system suspend to avoid that. Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com> --- drivers/net/wireless/marvell/mwifiex/main.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/wireless/marvell/mwifiex/main.c b/drivers/net/wireless/marvell/mwifiex/main.c index 5ebca1d..30f4994 100644 --- a/drivers/net/wireless/marvell/mwifiex/main.c +++ b/drivers/net/wireless/marvell/mwifiex/main.c @@ -17,6 +17,8 @@ * this warranty disclaimer. */ +#include <linux/suspend.h> + #include "main.h" #include "wmm.h" #include "cfg80211.h" @@ -1509,6 +1511,7 @@ static irqreturn_t mwifiex_irq_wakeup_handler(int irq, void *priv) /* Notify PM core we are wakeup source */ pm_wakeup_event(adapter->dev, 0); + pm_system_wakeup(); return IRQ_HANDLED; } -- 2.1.4 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 3/3] mwifiex: wake system up when receives a wake irq 2017-02-24 6:24 ` [PATCH 3/3] mwifiex: wake system up when receives a wake irq Jeffy Chen @ 2017-02-24 11:01 ` Kalle Valo 2017-02-24 12:20 ` jeffy 2017-03-20 16:44 ` [3/3] " Kalle Valo 1 sibling, 1 reply; 4+ messages in thread From: Kalle Valo @ 2017-02-24 11:01 UTC (permalink / raw) To: Jeffy Chen Cc: Amitkumar Karwar, Brian Norris, Rajat Jain, netdev, linux-wireless, linux-kernel, Nishant Sarmukadam Jeffy Chen <jeffy.chen@rock-chips.com> writes: > Currrently we are disabling this wake irq after receiving it. If this > happens before we finish suspend and the pm event check is disabled, > the system will continue suspending, and this irq would not work again. > > We may need to abort system suspend to avoid that. > > Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com> I only see patch 3 in patchwork. Where are patches 1 and 2? -- Kalle Valo ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 3/3] mwifiex: wake system up when receives a wake irq 2017-02-24 11:01 ` Kalle Valo @ 2017-02-24 12:20 ` jeffy 0 siblings, 0 replies; 4+ messages in thread From: jeffy @ 2017-02-24 12:20 UTC (permalink / raw) To: Kalle Valo Cc: Amitkumar Karwar, Brian Norris, Rajat Jain, netdev, linux-wireless, linux-kernel, Nishant Sarmukadam Hi Kalle, On 02/24/2017 07:01 PM, Kalle Valo wrote: > Jeffy Chen <jeffy.chen@rock-chips.com> writes: > >> Currrently we are disabling this wake irq after receiving it. If this >> happens before we finish suspend and the pm event check is disabled, >> the system will continue suspending, and this irq would not work again. >> >> We may need to abort system suspend to avoid that. >> >> Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com> > I only see patch 3 in patchwork. Where are patches 1 and 2? > the other two are much like this one, but for bluetooth :) please check: https://patchwork.kernel.org/patch/9589455 New [1/3] btusb: wake system up when receives a wake irq https://patchwork.kernel.org/patch/9589453 New [2/3] btmrvl: wake system up when receives a wake irq https://patchwork.kernel.org/patch/9589457 New [3/3] mwifiex: wake system up when receives a wake irq (sorry, this is a resent mail, because the last one was rejected due to wrong format) ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [3/3] mwifiex: wake system up when receives a wake irq 2017-02-24 6:24 ` [PATCH 3/3] mwifiex: wake system up when receives a wake irq Jeffy Chen 2017-02-24 11:01 ` Kalle Valo @ 2017-03-20 16:44 ` Kalle Valo 1 sibling, 0 replies; 4+ messages in thread From: Kalle Valo @ 2017-03-20 16:44 UTC (permalink / raw) To: Jeffy Chen Cc: Amitkumar Karwar, Brian Norris, Rajat Jain, Jeffy Chen, netdev, linux-wireless, linux-kernel, Nishant Sarmukadam Jeffy Chen <jeffy.chen@rock-chips.com> wrote: > Currrently we are disabling this wake irq after receiving it. If this > happens before we finish suspend and the pm event check is disabled, > the system will continue suspending, and this irq would not work again. > > We may need to abort system suspend to avoid that. > > Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com> Patch applied to wireless-drivers-next.git, thanks. ef7e07147425 mwifiex: wake system up when receives a wake irq -- https://patchwork.kernel.org/patch/9589459/ Documentation about submitting wireless patches and checking status from patchwork: https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-03-20 16:44 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- [not found] <1487917471-5501-1-git-send-email-jeffy.chen@rock-chips.com> 2017-02-24 6:24 ` [PATCH 3/3] mwifiex: wake system up when receives a wake irq Jeffy Chen 2017-02-24 11:01 ` Kalle Valo 2017-02-24 12:20 ` jeffy 2017-03-20 16:44 ` [3/3] " Kalle Valo
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).