From: Johannes Berg <johannes-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
To: Jiri Slaby <jslaby-AlSwsSmVLrQ@public.gmane.org>
Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
"Ondřej Lysoněk"
<ondrej.lysonek-9Vj9tDbzfuSlVyrhU4qvOw@public.gmane.org>,
"David S. Miller" <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>,
linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] mac80211: Use setup_timer instead of init_timer
Date: Mon, 06 Mar 2017 13:25:04 +0100 [thread overview]
Message-ID: <1488803104.5761.6.camel@sipsolutions.net> (raw)
In-Reply-To: <20170303124535.30125-1-jslaby-AlSwsSmVLrQ@public.gmane.org>
On Fri, 2017-03-03 at 13:45 +0100, Jiri Slaby wrote:
> From: Ondřej Lysoněk <ondrej.lysonek-9Vj9tDbzfuSlVyrhU4qvOw@public.gmane.org>
>
> Use setup_timer() and setup_deferrable_timer() to set the data and
> function timer fields. It makes the code cleaner and will allow for
> easier change of the timer struct internals.
Btw, I suspect you generated this with coccinelle and didn't put enough
"..." there, because you missed one in mesh_path_new() :)
Care to send a patch for that one too?
johannes
next prev parent reply other threads:[~2017-03-06 12:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-03 12:45 [PATCH] mac80211: Use setup_timer instead of init_timer Jiri Slaby
2017-03-06 12:23 ` Johannes Berg
[not found] ` <20170303124535.30125-1-jslaby-AlSwsSmVLrQ@public.gmane.org>
2017-03-06 12:25 ` Johannes Berg [this message]
2017-03-06 12:26 ` Johannes Berg
2017-03-06 12:35 ` Jiri Slaby
2017-03-06 12:36 ` Johannes Berg
[not found] ` <1488803104.5761.6.camel-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
2017-03-09 9:34 ` ondrej.lysonek-9Vj9tDbzfuSlVyrhU4qvOw
[not found] ` <20170309093436.25227-1-ondrej.lysonek-9Vj9tDbzfuSlVyrhU4qvOw@public.gmane.org>
2017-03-16 9:54 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1488803104.5761.6.camel@sipsolutions.net \
--to=johannes-cdvu00un1vgdhxzaddlk8q@public.gmane.org \
--cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org \
--cc=jslaby-AlSwsSmVLrQ@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=ondrej.lysonek-9Vj9tDbzfuSlVyrhU4qvOw@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).