netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Arcari <darcari@redhat.com>
To: netdev@vger.kernel.org
Cc: David Arcari <darcari@redhat.com>,
	Pavel Belous <Pavel.Belous@aquantia.com>
Subject: [PATCH] net: ethernet: aquantia: set net_device mtu when mtu is changed
Date: Wed,  8 Mar 2017 16:33:21 -0500	[thread overview]
Message-ID: <1489008801-120389-1-git-send-email-darcari@redhat.com> (raw)

When the aquantia device mtu is changed the net_device structure is not
updated.  As a result the ip command does not properly reflect the mtu change.

Commit 5513e16421cb incorrectly assumed that __dev_set_mtu() was making the
assignment ndev->mtu = new_mtu;  This is not true in the case where the driver
has a ndo_change_mtu routine.

Fixes: 5513e16421cb ("net: ethernet: aquantia: Fixes for aq_ndev_change_mtu")

Cc: Pavel Belous <Pavel.Belous@aquantia.com>
Signed-off-by: David Arcari <darcari@redhat.com>
---
 drivers/net/ethernet/aquantia/atlantic/aq_main.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/aquantia/atlantic/aq_main.c b/drivers/net/ethernet/aquantia/atlantic/aq_main.c
index dad6362..d05fbfd 100644
--- a/drivers/net/ethernet/aquantia/atlantic/aq_main.c
+++ b/drivers/net/ethernet/aquantia/atlantic/aq_main.c
@@ -98,6 +98,7 @@ static int aq_ndev_change_mtu(struct net_device *ndev, int new_mtu)
 
 	if (err < 0)
 		goto err_exit;
+	ndev->mtu = new_mtu;
 
 	if (netif_running(ndev)) {
 		aq_ndev_close(ndev);
-- 
1.8.3.1

             reply	other threads:[~2017-03-08 22:27 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-08 21:33 David Arcari [this message]
2017-03-09 19:02 ` [PATCH] net: ethernet: aquantia: set net_device mtu when mtu is changed Pavel Belous
2017-03-09 20:01   ` David Arcari
2017-03-09 20:28     ` David Arcari
2017-03-09 20:57       ` Pavel Belous
2017-03-13  6:09 ` David Miller
2017-03-13 15:50   ` David Arcari
2017-03-13 19:56     ` David Miller
2017-03-13 23:02       ` David Arcari
2017-03-15 20:49 ` Jarod Wilson
  -- strict thread matches above, loose matches on Subject: below --
2017-03-13 23:07 David Arcari
2017-03-14  1:32 ` Pavel Belous
2017-03-15 21:31 ` Jarod Wilson
2017-03-17  3:21 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1489008801-120389-1-git-send-email-darcari@redhat.com \
    --to=darcari@redhat.com \
    --cc=Pavel.Belous@aquantia.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).