From: Paolo Abeni <pabeni@redhat.com>
To: Eric Dumazet <edumazet@google.com>
Cc: Eric Dumazet <eric.dumazet@gmail.com>,
Dmitry Vyukov <dvyukov@google.com>,
David Miller <davem@davemloft.net>,
Cong Wang <xiyou.wangcong@gmail.com>,
Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
James Morris <jmorris@namei.org>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
Patrick McHardy <kaber@trash.net>,
netdev <netdev@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Jamal Hadi Salim <jhs@mojatatu.com>,
syzkaller <syzkaller@googlegroups.com>
Subject: Re: net: deadlock between ip_expire/sch_direct_xmit
Date: Tue, 14 Mar 2017 16:34:18 +0100 [thread overview]
Message-ID: <1489505658.2413.12.camel@redhat.com> (raw)
In-Reply-To: <CANn89iLB8UvDCQVoWZHeDKXX6te0x7C9NGsoJ_X9+8cF+mm0cg@mail.gmail.com>
On Tue, 2017-03-14 at 08:09 -0700, Eric Dumazet wrote:
> On Tue, Mar 14, 2017 at 8:03 AM, Paolo Abeni <pabeni@redhat.com> wrote:
>
> > I'm wondering if we really need to keep the fragment queue lock held
> > while sending the icmp packet ? we hold a reference to the struct, so
> > it can't be deleted, and AFAICS after ipq_kill() nobody else could
> > access/modify that queue.
> >
> > That lock is there pretty much forever, but perhaps is only a leftover
> > and we can release it just after ipq_kill() ?
>
> Maybe, but for peace of mind I would make sure this code path owns the
> skb (head) before releasing the lock.
>
> Seems something to try for net-next ?
Agreed.
I asked because I was in doubt I missed something obvious.
Thank you,
Paolo
next prev parent reply other threads:[~2017-03-14 15:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-14 13:31 net: deadlock between ip_expire/sch_direct_xmit Dmitry Vyukov
2017-03-14 14:41 ` Eric Dumazet
2017-03-14 14:46 ` Dmitry Vyukov
2017-03-14 14:56 ` Eric Dumazet
2017-03-14 14:58 ` Dmitry Vyukov
2017-03-14 16:41 ` Cong Wang
2017-03-20 9:59 ` Dmitry Vyukov
2017-03-20 12:43 ` Eric Dumazet
2017-03-14 15:03 ` Paolo Abeni
2017-03-14 15:09 ` Eric Dumazet
2017-03-14 15:34 ` Paolo Abeni [this message]
2017-03-22 15:57 ` [PATCH net] inet: frag: release spinlock before calling icmp_send() Eric Dumazet
2017-03-22 22:41 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1489505658.2413.12.camel@redhat.com \
--to=pabeni@redhat.com \
--cc=davem@davemloft.net \
--cc=dvyukov@google.com \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=jhs@mojatatu.com \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=syzkaller@googlegroups.com \
--cc=xiyou.wangcong@gmail.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).