netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Philippe Reynes <tremyfr-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: oliver-GvhC2dPhHPQdnm+yROfE0A@public.gmane.org,
	jacmet-OfajU3CKLf1/SzgSGea1oA@public.gmane.org,
	steve.glendinning-nksJyM/082jR7s880joybQ@public.gmane.org,
	UNGLinuxDriver-UWL1GkI3JZL3oGB3hsPCZA@public.gmane.org,
	gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org,
	davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org,
	robert.foss-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org,
	allan-knRN6Y/kmf1NUHwG+Fw1Kw@public.gmane.org,
	grundler-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org,
	jarod-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
	peter.chen-3arQi8VN3Tc@public.gmane.org,
	stefan.bruens-vA1bhqPz9FBZXbeN9DUtxg@public.gmane.org,
	akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org,
	adobriyan-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
Cc: linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Philippe Reynes <tremyfr-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Subject: [PATCH 04/11] net: usb: cdc_ncm: use new api ethtool_{get|set}_link_ksettings
Date: Thu, 16 Mar 2017 23:18:50 +0100	[thread overview]
Message-ID: <1489702737-2401-5-git-send-email-tremyfr@gmail.com> (raw)
In-Reply-To: <1489702737-2401-1-git-send-email-tremyfr-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

The ethtool api {get|set}_settings is deprecated.
We move this driver to new api {get|set}_link_ksettings.

As I don't have the hardware, I'd be very pleased if
someone may test this patch.

Signed-off-by: Philippe Reynes <tremyfr-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
---
 drivers/net/usb/cdc_ncm.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/usb/cdc_ncm.c b/drivers/net/usb/cdc_ncm.c
index f317984..b6c1d3a 100644
--- a/drivers/net/usb/cdc_ncm.c
+++ b/drivers/net/usb/cdc_ncm.c
@@ -131,8 +131,6 @@ static void cdc_ncm_get_strings(struct net_device __always_unused *netdev, u32 s
 static void cdc_ncm_update_rxtx_max(struct usbnet *dev, u32 new_rx, u32 new_tx);
 
 static const struct ethtool_ops cdc_ncm_ethtool_ops = {
-	.get_settings      = usbnet_get_settings,
-	.set_settings      = usbnet_set_settings,
 	.get_link          = usbnet_get_link,
 	.nway_reset        = usbnet_nway_reset,
 	.get_drvinfo       = usbnet_get_drvinfo,
@@ -142,6 +140,8 @@ static void cdc_ncm_get_strings(struct net_device __always_unused *netdev, u32 s
 	.get_sset_count    = cdc_ncm_get_sset_count,
 	.get_strings       = cdc_ncm_get_strings,
 	.get_ethtool_stats = cdc_ncm_get_ethtool_stats,
+	.get_link_ksettings      = usbnet_get_link_ksettings,
+	.set_link_ksettings      = usbnet_set_link_ksettings,
 };
 
 static u32 cdc_ncm_check_rx_max(struct usbnet *dev, u32 new_rx)
-- 
1.7.4.4

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2017-03-16 22:18 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-16 22:18 [PATCH 00/11] net: usbnet: move to new api ethtool_{get|set}_link_ksettings Philippe Reynes
2017-03-16 22:18 ` [PATCH 01/11] net: usb: usbnet: add " Philippe Reynes
2017-03-20  6:39   ` Oliver Neukum
2017-03-21 11:33   ` Oliver Neukum
2017-03-21 23:03     ` David Miller
2017-03-16 22:18 ` [PATCH 02/11] net: usb: smsc95xx: use " Philippe Reynes
2017-03-16 22:18 ` [PATCH 03/11] net: usb: sr9800: " Philippe Reynes
     [not found] ` <1489702737-2401-1-git-send-email-tremyfr-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-03-16 22:18   ` Philippe Reynes [this message]
2017-03-16 22:18 ` [PATCH 05/11] net: usb: dm9601: " Philippe Reynes
2017-03-16 22:18 ` [PATCH 06/11] net: usb: mcs7830: " Philippe Reynes
2017-03-21 14:36   ` poma
2017-03-16 22:18 ` [PATCH 07/11] net: usb: sierra_net: " Philippe Reynes
2017-03-16 22:18 ` [PATCH 08/11] net: usb: smsc75xx: " Philippe Reynes
2017-03-16 22:18 ` [PATCH 09/11] net: usb: sr9700: " Philippe Reynes
2017-03-16 22:18 ` [PATCH 10/11] net: usb: asix: " Philippe Reynes
2017-03-16 22:18 ` [PATCH 11/11] net: usb: usb: remove old api ethtool_{get|set}_settings Philippe Reynes
     [not found]   ` <1489702737-2401-12-git-send-email-tremyfr-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-03-20  6:40     ` Oliver Neukum
2017-03-21 23:04 ` [PATCH 00/11] net: usbnet: move to new api ethtool_{get|set}_link_ksettings David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1489702737-2401-5-git-send-email-tremyfr@gmail.com \
    --to=tremyfr-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
    --cc=UNGLinuxDriver-UWL1GkI3JZL3oGB3hsPCZA@public.gmane.org \
    --cc=adobriyan-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
    --cc=allan-knRN6Y/kmf1NUHwG+Fw1Kw@public.gmane.org \
    --cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org \
    --cc=gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org \
    --cc=grundler-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
    --cc=jacmet-OfajU3CKLf1/SzgSGea1oA@public.gmane.org \
    --cc=jarod-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=oliver-GvhC2dPhHPQdnm+yROfE0A@public.gmane.org \
    --cc=peter.chen-3arQi8VN3Tc@public.gmane.org \
    --cc=robert.foss-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org \
    --cc=stefan.bruens-vA1bhqPz9FBZXbeN9DUtxg@public.gmane.org \
    --cc=steve.glendinning-nksJyM/082jR7s880joybQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).