* [PATCH v1] NFC: Add nfc_dbg() macro
@ 2017-03-22 19:22 Andy Shevchenko
2017-03-26 12:37 ` Andy Shevchenko
2017-04-05 8:16 ` Samuel Ortiz
0 siblings, 2 replies; 3+ messages in thread
From: Andy Shevchenko @ 2017-03-22 19:22 UTC (permalink / raw)
To: Lauro Ramos Venancio, Aloisio Almeida Jr, Samuel Ortiz,
linux-wireless-u79uwXL29TY76Z2rM5mHXA, David S. Miller,
netdev-u79uwXL29TY76Z2rM5mHXA
Cc: Andy Shevchenko
In some cases nfc_dbg() is useful. Add such macro to a header.
Signed-off-by: Andy Shevchenko <andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
---
include/net/nfc/nfc.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/net/nfc/nfc.h b/include/net/nfc/nfc.h
index 1a3de8b34ad2..bbdc73a3239d 100644
--- a/include/net/nfc/nfc.h
+++ b/include/net/nfc/nfc.h
@@ -27,6 +27,7 @@
#include <linux/device.h>
#include <linux/skbuff.h>
+#define nfc_dbg(dev, fmt, ...) dev_dbg((dev), "NFC: " fmt, ##__VA_ARGS__)
#define nfc_info(dev, fmt, ...) dev_info((dev), "NFC: " fmt, ##__VA_ARGS__)
#define nfc_err(dev, fmt, ...) dev_err((dev), "NFC: " fmt, ##__VA_ARGS__)
--
2.11.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v1] NFC: Add nfc_dbg() macro
2017-03-22 19:22 [PATCH v1] NFC: Add nfc_dbg() macro Andy Shevchenko
@ 2017-03-26 12:37 ` Andy Shevchenko
2017-04-05 8:16 ` Samuel Ortiz
1 sibling, 0 replies; 3+ messages in thread
From: Andy Shevchenko @ 2017-03-26 12:37 UTC (permalink / raw)
To: Lauro Ramos Venancio, Aloisio Almeida Jr, Samuel Ortiz,
linux-wireless, David S. Miller, netdev
On Wed, 2017-03-22 at 21:22 +0200, Andy Shevchenko wrote:
> In some cases nfc_dbg() is useful. Add such macro to a header.
>
I think we may drop this, since the idea is to get rid of such macros
(as I read back in 2011 in commit message of change that removed
nfc_dbg() one).
I will re-do dependent series to not use it at all.
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> include/net/nfc/nfc.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/net/nfc/nfc.h b/include/net/nfc/nfc.h
> index 1a3de8b34ad2..bbdc73a3239d 100644
> --- a/include/net/nfc/nfc.h
> +++ b/include/net/nfc/nfc.h
> @@ -27,6 +27,7 @@
> #include <linux/device.h>
> #include <linux/skbuff.h>
>
> +#define nfc_dbg(dev, fmt, ...) dev_dbg((dev), "NFC: " fmt,
> ##__VA_ARGS__)
> #define nfc_info(dev, fmt, ...) dev_info((dev), "NFC: " fmt,
> ##__VA_ARGS__)
> #define nfc_err(dev, fmt, ...) dev_err((dev), "NFC: " fmt,
> ##__VA_ARGS__)
>
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v1] NFC: Add nfc_dbg() macro
2017-03-22 19:22 [PATCH v1] NFC: Add nfc_dbg() macro Andy Shevchenko
2017-03-26 12:37 ` Andy Shevchenko
@ 2017-04-05 8:16 ` Samuel Ortiz
1 sibling, 0 replies; 3+ messages in thread
From: Samuel Ortiz @ 2017-04-05 8:16 UTC (permalink / raw)
To: Andy Shevchenko; +Cc: linux-wireless, David S. Miller, netdev
On Wed, Mar 22, 2017 at 09:22:51PM +0200, Andy Shevchenko wrote:
> In some cases nfc_dbg() is useful. Add such macro to a header.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> include/net/nfc/nfc.h | 1 +
> 1 file changed, 1 insertion(+)
Applied as well.
Cheers,
Samuel.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-04-05 8:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-03-22 19:22 [PATCH v1] NFC: Add nfc_dbg() macro Andy Shevchenko
2017-03-26 12:37 ` Andy Shevchenko
2017-04-05 8:16 ` Samuel Ortiz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).