From: Zhu Yanjun <yanjun.zhu@oracle.com>
To: yanjun.zhu@oracle.com, santosh.shilimkar@oracle.com,
netdev@vger.kernel.org, linux-rdma@vger.kernel.org,
rds-devel@oss.oracle.com, junxiao.bi@oracle.com,
joe.jin@oracle.com
Subject: [PATCH 2/5] rds: rdma: fix memory leak error
Date: Mon, 27 Mar 2017 03:06:27 -0400 [thread overview]
Message-ID: <1490598390-13812-3-git-send-email-yanjun.zhu@oracle.com> (raw)
In-Reply-To: <1490598390-13812-1-git-send-email-yanjun.zhu@oracle.com>
In the function __rds_rdma_map, the allocated memory and other
resources should be freed when some error occurs.
Signed-off-by: Zhu Yanjun <yanjun.zhu@oracle.com>
---
net/rds/rdma.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/net/rds/rdma.c b/net/rds/rdma.c
index f06fac4..ad9b6bd 100644
--- a/net/rds/rdma.c
+++ b/net/rds/rdma.c
@@ -253,6 +253,8 @@ static int __rds_rdma_map(struct rds_sock *rs, struct rds_get_mr_args *args,
sg = kcalloc(nents, sizeof(*sg), GFP_KERNEL);
if (!sg) {
ret = -ENOMEM;
+ for (i = 0; i < nents; i++)
+ put_page(pages[i]);
goto out;
}
WARN_ON(!nents);
@@ -293,6 +295,11 @@ static int __rds_rdma_map(struct rds_sock *rs, struct rds_get_mr_args *args,
*cookie_ret = cookie;
if (args->cookie_addr && put_user(cookie, (u64 __user *)(unsigned long) args->cookie_addr)) {
+ for (i = 0; i < nents; i++)
+ put_page(sg_page(&sg[i]));
+ kfree(sg);
+ mr->r_trans->free_mr(mr->r_trans_private, 1);
+ mr->r_trans_private = NULL;
ret = -EFAULT;
goto out;
}
--
2.7.4
next prev parent reply other threads:[~2017-03-27 7:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-27 7:06 [PATCH 0/5] rds: trivial patches Zhu Yanjun
[not found] ` <1490598390-13812-1-git-send-email-yanjun.zhu-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2017-03-27 7:06 ` [PATCH 1/5] rds: tcp: release the created connection Zhu Yanjun
2017-03-27 7:37 ` Sowmini Varadhan
[not found] ` <20170327073756.GA21982-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2017-03-27 8:05 ` Yanjun Zhu
2017-03-27 9:17 ` Sowmini Varadhan
2017-03-27 7:06 ` [PATCH 3/5] rds: remove unnecessary returned value check Zhu Yanjun
2017-03-27 7:06 ` [PATCH 5/5] rds: ib: add the static type to the functions Zhu Yanjun
2017-03-27 7:06 ` Zhu Yanjun [this message]
2017-03-27 7:06 ` [PATCH 4/5] rds: remove the unused variable Zhu Yanjun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1490598390-13812-3-git-send-email-yanjun.zhu@oracle.com \
--to=yanjun.zhu@oracle.com \
--cc=joe.jin@oracle.com \
--cc=junxiao.bi@oracle.com \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rds-devel@oss.oracle.com \
--cc=santosh.shilimkar@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).