* [PATCH net-next] virtio_net: don't reset twice on XDP on/off
@ 2017-03-29 20:14 Michael S. Tsirkin
2017-03-30 5:39 ` Jason Wang
0 siblings, 1 reply; 2+ messages in thread
From: Michael S. Tsirkin @ 2017-03-29 20:14 UTC (permalink / raw)
To: linux-kernel; +Cc: netdev, John Fastabend, virtualization
We already do a reset once in remove_vq_common -
there appears to be no point in doing another one
when we add/remove XDP.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
drivers/net/virtio_net.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
index de42e9a..ed8f548 100644
--- a/drivers/net/virtio_net.c
+++ b/drivers/net/virtio_net.c
@@ -1810,7 +1810,6 @@ static int virtnet_reset(struct virtnet_info *vi, int curr_qp, int xdp_qp)
virtnet_freeze_down(dev);
_remove_vq_common(vi);
- dev->config->reset(dev);
virtio_add_status(dev, VIRTIO_CONFIG_S_ACKNOWLEDGE);
virtio_add_status(dev, VIRTIO_CONFIG_S_DRIVER);
--
MST
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] virtio_net: don't reset twice on XDP on/off
2017-03-29 20:14 [PATCH net-next] virtio_net: don't reset twice on XDP on/off Michael S. Tsirkin
@ 2017-03-30 5:39 ` Jason Wang
0 siblings, 0 replies; 2+ messages in thread
From: Jason Wang @ 2017-03-30 5:39 UTC (permalink / raw)
To: Michael S. Tsirkin, linux-kernel; +Cc: netdev, John Fastabend, virtualization
On 2017年03月30日 04:14, Michael S. Tsirkin wrote:
> We already do a reset once in remove_vq_common -
> there appears to be no point in doing another one
> when we add/remove XDP.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> drivers/net/virtio_net.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
> index de42e9a..ed8f548 100644
> --- a/drivers/net/virtio_net.c
> +++ b/drivers/net/virtio_net.c
> @@ -1810,7 +1810,6 @@ static int virtnet_reset(struct virtnet_info *vi, int curr_qp, int xdp_qp)
> virtnet_freeze_down(dev);
> _remove_vq_common(vi);
>
> - dev->config->reset(dev);
> virtio_add_status(dev, VIRTIO_CONFIG_S_ACKNOWLEDGE);
> virtio_add_status(dev, VIRTIO_CONFIG_S_DRIVER);
>
Acked-by: Jason Wang <jasowang@redhat.com>
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-03-30 5:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-03-29 20:14 [PATCH net-next] virtio_net: don't reset twice on XDP on/off Michael S. Tsirkin
2017-03-30 5:39 ` Jason Wang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).