From: Yi-Hung Wei <yihung.wei@gmail.com>
To: jbenc@redhat.com, joe@ovn.org, netdev@vger.kernel.org
Cc: Yi-Hung Wei <yihung.wei@gmail.com>, linux-kernel@vger.kernel.org
Subject: [PATCH net] openvswitch: Fix ovs_flow_key_update()
Date: Wed, 29 Mar 2017 17:14:10 -0700 [thread overview]
Message-ID: <1490832850-6012-1-git-send-email-yihung.wei@gmail.com> (raw)
ovs_flow_key_update() is called when the flow key is invalid, and it is
used to update and revalidate the flow key. Commit 329f45bc4f19
("openvswitch: add mac_proto field to the flow key") introduces mac_proto
field to flow key and use it to determine whether the flow key is valid.
However, the commit does not update the code path in ovs_flow_key_update()
to revalidate the flow key which may cause BUG_ON() on execute_recirc().
This patch addresses the aforementioned issue.
Fixes: 329f45bc4f19 ("openvswitch: add mac_proto field to the flow key")
Signed-off-by: Yi-Hung Wei <yihung.wei@gmail.com>
---
net/openvswitch/flow.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/net/openvswitch/flow.c b/net/openvswitch/flow.c
index 9d4bb8eb63f2..bb33f5341294 100644
--- a/net/openvswitch/flow.c
+++ b/net/openvswitch/flow.c
@@ -53,6 +53,8 @@
#include "flow_netlink.h"
#include "vport.h"
+static int key_extract_mac_proto(struct sk_buff *skb);
+
u64 ovs_flow_used_time(unsigned long flow_jiffies)
{
struct timespec cur_ts;
@@ -745,6 +747,13 @@ static int key_extract(struct sk_buff *skb, struct sw_flow_key *key)
int ovs_flow_key_update(struct sk_buff *skb, struct sw_flow_key *key)
{
+ int res;
+
+ res = key_extract_mac_proto(skb);
+ if (res < 0)
+ return res;
+ key->mac_proto = res;
+
return key_extract(skb, key);
}
--
2.7.4
next reply other threads:[~2017-03-30 0:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-30 0:14 Yi-Hung Wei [this message]
2017-03-30 13:22 ` [PATCH net] openvswitch: Fix ovs_flow_key_update() Jiri Benc
2017-03-30 18:39 ` Yi-Hung Wei
2017-03-30 18:47 ` Jiri Benc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1490832850-6012-1-git-send-email-yihung.wei@gmail.com \
--to=yihung.wei@gmail.com \
--cc=jbenc@redhat.com \
--cc=joe@ovn.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).