From: Dan Williams <dcbw@redhat.com>
To: Rene Rebe <rene@exactcode.com>, davem@davemloft.net
Cc: netdev@vger.kernel.org, nic_swsd@realtek.com
Subject: Re: [PATCH] r8152: The Microsoft Surface docks also use R8152.
Date: Thu, 30 Mar 2017 12:06:05 -0500 [thread overview]
Message-ID: <1490893565.24247.9.camel@redhat.com> (raw)
In-Reply-To: <20170328.064215.1055636797214516339.rene@exactcode.com>
On Tue, 2017-03-28 at 06:42 +0200, Rene Rebe wrote:
> Without this the generic cdc_ether grabs the device,
> and does not really work.
Does this need a corresponding blacklist in cdc_ether then? Otherwise
you're really depending on driver loading order.
Dan
> Signed-off-by: René Rebe <rene@exactcode.com>
>
> diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c
> index c34df33..07f788c 100644
> --- a/drivers/net/usb/r8152.c
> +++ b/drivers/net/usb/r8152.c
> @@ -517,6 +517,7 @@ enum rtl8152_flags {
>
> /* Define these values to match your device */
> #define VENDOR_ID_REALTEK 0x0bda
> +#define VENDOR_ID_MICROSOFT 0x045e
> #define VENDOR_ID_SAMSUNG 0x04e8
> #define VENDOR_ID_LENOVO 0x17ef
> #define VENDOR_ID_NVIDIA 0x0955
> @@ -4521,6 +4522,8 @@ static void rtl8152_disconnect(struct
> usb_interface *intf)
> static struct usb_device_id rtl8152_table[] = {
> {REALTEK_USB_DEVICE(VENDOR_ID_REALTEK, 0x8152)},
> {REALTEK_USB_DEVICE(VENDOR_ID_REALTEK, 0x8153)},
> + {REALTEK_USB_DEVICE(VENDOR_ID_MICROSOFT, 0x07ab)},
> + {REALTEK_USB_DEVICE(VENDOR_ID_MICROSOFT, 0x07c6)},
> {REALTEK_USB_DEVICE(VENDOR_ID_SAMSUNG, 0xa101)},
> {REALTEK_USB_DEVICE(VENDOR_ID_LENOVO, 0x304f)},
> {REALTEK_USB_DEVICE(VENDOR_ID_LENOVO, 0x3062)},
>
>
> --
> René Rebe, ExactCODE GmbH, Lietzenburger Str. 42, DE-10789 Berlin
> http://exactcode.com | http://t2-project.org | http://rene.rebe.de
next prev parent reply other threads:[~2017-03-30 17:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-13 17:06 [PATCH] r8152 add Microsoft Dock IDs René Rebe
2016-01-13 19:51 ` David Miller
2016-01-13 20:03 ` René Rebe
2016-01-13 20:49 ` David Miller
2017-03-28 4:42 ` [PATCH] r8152: The Microsoft Surface docks also use R8152 Rene Rebe
2017-03-30 17:06 ` Dan Williams [this message]
2017-03-28 5:56 ` [PATCH] r8152: The Microsoft Surface docks also use R8152 v2 Rene Rebe
2017-04-01 19:20 ` David Miller
2017-03-30 17:47 ` [PATCH] r8152: The Microsoft Surface docks also use R8152 René Rebe
2017-03-30 18:12 ` Dan Williams
2017-03-28 6:00 ` Rene Rebe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1490893565.24247.9.camel@redhat.com \
--to=dcbw@redhat.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
--cc=rene@exactcode.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).