From: Joe Perches <joe@perches.com>
To: Arushi Singhal <arushisinghal19971997@gmail.com>, pablo@netfilter.org
Cc: Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>,
"David S. Miller" <davem@davemloft.net>,
Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
James Morris <jmorris@namei.org>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
Patrick McHardy <kaber@trash.net>,
netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ipv4: netfilter: Comparison to NULL could be written
Date: Sat, 01 Apr 2017 06:05:59 -0700 [thread overview]
Message-ID: <1491051959.27353.40.camel@perches.com> (raw)
In-Reply-To: <20170401083520.GA2037@arushi-HP-Pavilion-Notebook>
On Sat, 2017-04-01 at 14:05 +0530, Arushi Singhal wrote:
> Fixed coding style for null comparisons to be more
> consistant with the rest of the kernel coding style.
typo: consistent and trivia:
> diff --git a/net/ipv4/netfilter/arp_tables.c b/net/ipv4/netfilter/arp_tables.c
[]
> @@ -653,7 +653,7 @@ static struct xt_counters *alloc_counters(const struct xt_table *table)
> countersize = sizeof(struct xt_counters) * private->number;
> counters = vzalloc(countersize);
>
> - if (counters == NULL)
> + if (!counters)
> return ERR_PTR(-ENOMEM);
This could also remove the blank link above the test.
prev parent reply other threads:[~2017-04-01 13:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-01 8:35 [PATCH] ipv4: netfilter: Comparison to NULL could be written Arushi Singhal
2017-04-01 13:05 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1491051959.27353.40.camel@perches.com \
--to=joe@perches.com \
--cc=arushisinghal19971997@gmail.com \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=kadlec@blackhole.kfki.hu \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).