From: Joe Perches <joe@perches.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] phy/ethtool: Add missing SPEED_<foo> strings
Date: Sun, 02 Apr 2017 14:49:18 -0700 [thread overview]
Message-ID: <1491169758.27353.50.camel@perches.com> (raw)
In-Reply-To: <20170402214031.GH5189@lunn.ch>
On Sun, 2017-04-02 at 23:40 +0200, Andrew Lunn wrote:
> On Sun, Apr 02, 2017 at 02:30:06PM -0700, Joe Perches wrote:
> > Add all the currently available SPEED_<foo> strings.
[]
> > diff --git a/include/uapi/linux/ethtool.h b/include/uapi/linux/ethtool.h
[]
> > @@ -1487,6 +1487,7 @@ enum ethtool_link_mode_bit_indices {
> > */
> >
> > /* The forced speed, in units of 1Mb. All values 0 to INT_MAX are legal. */
>
> Hi Joe
>
> Given that this list is getting longer and longer, and the comment
> that 0..INT_MAX are legal, is it time to replace this with something
> dynamic?
Hey Andrew.
Probably not.
INT_MAX in units of millions is likely large enough for
quite awhile yet, maybe 2 decades or even more.
If you feel ambitious, and remember ethtool.h and
SPEED_<foo> uses are a public API, write something up.
cheers, Joe
next prev parent reply other threads:[~2017-04-02 21:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-02 21:30 [PATCH] phy/ethtool: Add missing SPEED_<foo> strings Joe Perches
2017-04-02 21:40 ` Andrew Lunn
2017-04-02 21:49 ` Joe Perches [this message]
2017-04-02 22:29 ` Florian Fainelli
2017-04-03 2:44 ` Joe Perches
2017-04-05 13:36 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1491169758.27353.50.camel@perches.com \
--to=joe@perches.com \
--cc=andrew@lunn.ch \
--cc=f.fainelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox