From: Joe Perches <joe@perches.com>
To: Florian Fainelli <f.fainelli@gmail.com>, Andrew Lunn <andrew@lunn.ch>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] phy/ethtool: Add missing SPEED_<foo> strings
Date: Sun, 02 Apr 2017 19:44:06 -0700 [thread overview]
Message-ID: <1491187446.27353.52.camel@perches.com> (raw)
In-Reply-To: <c7baf39b-4d4a-93f2-6975-d170a53a6ef2@gmail.com>
On Sun, 2017-04-02 at 15:29 -0700, Florian Fainelli wrote:
> Le 04/02/17 à 14:30, Joe Perches a écrit :
> > Add all the currently available SPEED_<foo> strings.
> >
> > Signed-off-by: Joe Perches <joe@perches.com>
>
> Considering that PHYLIB does not support anything > 10Gbs at the moment,
> I am not sure how useful that is except if we wanted to re-use
> phy_speed_to_str() in other places of the kernel?
phy_print_status() can be used several places already
independent of phylib.
Might as well make it more generic and so more usable.
next prev parent reply other threads:[~2017-04-03 2:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-02 21:30 [PATCH] phy/ethtool: Add missing SPEED_<foo> strings Joe Perches
2017-04-02 21:40 ` Andrew Lunn
2017-04-02 21:49 ` Joe Perches
2017-04-02 22:29 ` Florian Fainelli
2017-04-03 2:44 ` Joe Perches [this message]
2017-04-05 13:36 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1491187446.27353.52.camel@perches.com \
--to=joe@perches.com \
--cc=andrew@lunn.ch \
--cc=f.fainelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox