From: Cong Wang <xiyou.wangcong@gmail.com>
To: netdev@vger.kernel.org
Cc: efault@gmx.de, Cong Wang <xiyou.wangcong@gmail.com>
Subject: [Patch net] net_sched: replace yield() with cond_resched()
Date: Tue, 4 Apr 2017 18:52:19 -0700 [thread overview]
Message-ID: <1491357139-27108-1-git-send-email-xiyou.wangcong@gmail.com> (raw)
yield() should be rendered dead, according to Mike.
It is hard to wait properly for all qdisc's to transmit
all packets. So just keep the original logic.
Reported-by: Mike Galbraith <efault@gmx.de>
Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
---
net/sched/sch_generic.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/sched/sch_generic.c b/net/sched/sch_generic.c
index 1a2f9e9..4725d2f 100644
--- a/net/sched/sch_generic.c
+++ b/net/sched/sch_generic.c
@@ -925,7 +925,7 @@ void dev_deactivate_many(struct list_head *head)
/* Wait for outstanding qdisc_run calls. */
list_for_each_entry(dev, head, close_list)
while (some_qdisc_is_busy(dev))
- yield();
+ cond_resched();
}
void dev_deactivate(struct net_device *dev)
--
2.5.5
next reply other threads:[~2017-04-05 1:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-05 1:52 Cong Wang [this message]
2017-04-05 3:55 ` [Patch net] net_sched: replace yield() with cond_resched() Mike Galbraith
2017-04-05 5:19 ` Cong Wang
2017-04-05 5:56 ` Mike Galbraith
2017-04-05 23:42 ` Cong Wang
2017-04-06 1:54 ` Mike Galbraith
2017-04-06 22:13 ` Stephen Hemminger
2017-04-07 3:59 ` Mike Galbraith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1491357139-27108-1-git-send-email-xiyou.wangcong@gmail.com \
--to=xiyou.wangcong@gmail.com \
--cc=efault@gmx.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).