Re: [PATCH v7 08/24] wfx: add bus_sdio.c

Ulf Hansson
2021-09-30T10:08:36Z

On Mon, 20 Sept 2021 at 18:12, Jerome Pouiller
<Jerome.Pouiller@silabs.com> wrote:
>
> From: Jérôme Pouiller <jerome.pouiller@silabs.com>
>
> Signed-off-by: Jérôme Pouiller <jerome.pouiller@silabs.com>
> ---
> drivers/net/wireless/silabs/wfx/bus_sdio.c | 261 +++++++++++++++++++++
> 1 file changed, 261 insertions(+)
> create mode 100644 drivers/net/wireless/silabs/wfx/bus_sdio.c
>
> diff --git a/drivers/net/wireless/silabs/wfx/bus_sdio.c b/drivers/net/wireless/silabs/wfx/bus_sdio.c

[...]

> +
> +static int wfx_sdio_probe(struct sdio_func *func,
> + const struct sdio_device_id *id)
> +{
> + struct device_node *np = func->dev.of_node;
> + struct wfx_sdio_priv *bus;
> + int ret;
> +
> + if (func->num != 1) {
> + dev_err(&func->dev, "SDIO function number is %d while it should always be 1 (unsupported chip?)\n",
> + func->num);
> + return -ENODEV;
> + }
> +
> + bus = devm_kzalloc(&func->dev, sizeof(*bus), GFP_KERNEL);
> + if (!bus)
> + return -ENOMEM;
> +
> + if (!np || !of_match_node(wfx_sdio_of_match, np)) {
> + dev_warn(&func->dev, "no compatible device found in DT\n");
> + return -ENODEV;
> + }
> +
> + bus->func = func;
> + bus->of_irq = irq_of_parse_and_map(np, 0);
> + sdio_set_drvdata(func, bus);
> + func->card->quirks |= MMC_QUIRK_LENIENT_FN0 |
> + MMC_QUIRK_BLKSZ_FOR_BYTE_MODE |
> + MMC_QUIRK_BROKEN_BYTE_MODE_512;

I would rather see that you add an SDIO_FIXUP for the SDIO card, to
the sdio_fixup_methods[], in drivers/mmc/core/quirks.h, instead of
this.

> +
> + sdio_claim_host(func);
> + ret = sdio_enable_func(func);
> + /* Block of 64 bytes is more efficient than 512B for frame sizes < 4k */
> + sdio_set_block_size(func, 64);
> + sdio_release_host(func);
> + if (ret)
> + return ret;
> +
> + bus->core = wfx_init_common(&func->dev, &wfx_sdio_pdata,
> + &wfx_sdio_hwbus_ops, bus);
> + if (!bus->core) {
> + ret = -EIO;
> + goto sdio_release;
> + }
> +
> + ret = wfx_probe(bus->core);
> + if (ret)
> + goto sdio_release;
> +
> + return 0;
> +
> +sdio_release:
> + sdio_claim_host(func);
> + sdio_disable_func(func);
> + sdio_release_host(func);
> + return ret;
> +}
> +
> +static void wfx_sdio_remove(struct sdio_func *func)
> +{
> + struct wfx_sdio_priv *bus = sdio_get_drvdata(func);
> +
> + wfx_release(bus->core);
> + sdio_claim_host(func);
> + sdio_disable_func(func);
> + sdio_release_host(func);
> +}
> +
> +static const struct sdio_device_id wfx_sdio_ids[] = {
> + { SDIO_DEVICE(SDIO_VENDOR_ID_SILABS, SDIO_DEVICE_ID_SILABS_WF200) },
> + { },
> +};
> +MODULE_DEVICE_TABLE(sdio, wfx_sdio_ids);
> +
> +struct sdio_driver wfx_sdio_driver = {
> + .name = "wfx-sdio",
> + .id_table = wfx_sdio_ids,
> + .probe = wfx_sdio_probe,
> + .remove = wfx_sdio_remove,
> + .drv = {
> + .owner = THIS_MODULE,
> + .of_match_table = wfx_sdio_of_match,

Is there no power management? Or do you intend to add that on top?

> + }
> +};
> --
> 2.33.0
>

Kind regards
Uffe