From: Johannes Berg <johannes@sipsolutions.net>
To: Matthias Kaehlcke <mka@chromium.org>
Cc: "David S . Miller" <davem@davemloft.net>,
linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org,
netdev@vger.kernel.org, Grant Grundler <grundler@chromium.org>,
Michael Davidson <md@google.com>,
Greg Hackmann <ghackmann@google.com>
Subject: Re: [PATCH] mac80211: Fix clang warning about constant operand in logical operation
Date: Fri, 07 Apr 2017 00:51:57 +0200 [thread overview]
Message-ID: <1491519117.11399.10.camel@sipsolutions.net> (raw)
In-Reply-To: <20170406224238.GA78690@google.com> (sfid-20170407_004241_473279_B0243983)
On Thu, 2017-04-06 at 15:42 -0700, Matthias Kaehlcke wrote:
>
> Thanks, it would also require to move the initialization of
> ieee80211_default_rc_algo into an ifdef. If you can live with such a
> solution I'm happy to change it.
I think that'd be something I can live with, yeah.
> > git grep 'IS_ENABLED(' | grep '&&'
>
> Indeed the warning is not triggered by these constructs. It seems
> clang only emits the warning when the constant operand is not
> boolean.
That points to just adding "> 0" to the condition here as another
alternative solution, I guess? With a comment to make sure it's not
removed again, that'd seem like the best thing to do.
johannes
next prev parent reply other threads:[~2017-04-06 22:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-06 18:56 [PATCH] mac80211: Fix clang warning about constant operand in logical operation Matthias Kaehlcke
[not found] ` <20170406185633.91065-1-mka-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2017-04-06 19:11 ` Johannes Berg
2017-04-06 19:24 ` Matthias Kaehlcke
[not found] ` <20170406192452.GE145051-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2017-04-06 21:12 ` Johannes Berg
2017-04-06 22:42 ` Matthias Kaehlcke
2017-04-06 22:51 ` Johannes Berg [this message]
2017-04-06 23:07 ` Matthias Kaehlcke
2017-04-10 14:12 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1491519117.11399.10.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=davem@davemloft.net \
--cc=ghackmann@google.com \
--cc=grundler@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=md@google.com \
--cc=mka@chromium.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).