netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Documentation error for checksum offload check ?
@ 2017-04-07  0:23 Benjamin Herrenschmidt
  2017-04-07  7:35 ` Davide Caratti
  0 siblings, 1 reply; 2+ messages in thread
From: Benjamin Herrenschmidt @ 2017-04-07  0:23 UTC (permalink / raw)
  To: netdev

I noticed in both Documentation/networking/checksum-offload.txt
and include/linux/skbuff.h reference to helpers

skb_csum_off_chk*

Now, I can't find anything like that with grep ... :-)

Am I missing something ?

Cheers,
Ben.

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: Documentation error for checksum offload check ?
  2017-04-07  0:23 Documentation error for checksum offload check ? Benjamin Herrenschmidt
@ 2017-04-07  7:35 ` Davide Caratti
  0 siblings, 0 replies; 2+ messages in thread
From: Davide Caratti @ 2017-04-07  7:35 UTC (permalink / raw)
  To: Benjamin Herrenschmidt, netdev

On Fri, 2017-04-07 at 10:23 +1000, Benjamin Herrenschmidt wrote:
> I noticed in both Documentation/networking/checksum-offload.txt
> and include/linux/skbuff.h reference to helpers
> 
> skb_csum_off_chk*
> c
> Now, I can't find anything like that with grep ... :-)
> 
> Am I missing something ?
> 
> Cheers,
> Ben.
> 

hello Benjamin,

these functions are not present anymore in the kernel since commit
cf53b1da73bd ('Revert "net: Add driver helper functions to determine
checksum"'). You might find some additional information on this thread
in linux-sctp (https://www.spinics.net/lists/linux-sctp/msg05606.html),
there is an ongoing proposal for fixing Documentation/networking/checksum-offload.txt,
improve referenced paragraphs in include/linux/sk_buff.h, and maybe
extend the current API.

regards,

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-04-07  7:35 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-04-07  0:23 Documentation error for checksum offload check ? Benjamin Herrenschmidt
2017-04-07  7:35 ` Davide Caratti

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).