From: David Ahern <dsa@cumulusnetworks.com>
To: netdev@vger.kernel.org
Cc: vyasevic@redhat.com, davem@davemloft.net,
David Ahern <dsa@cumulusnetworks.com>
Subject: [PATCH net-next 5/8] rtnetlink: Remove NETDEV_CHANGEINFODATA netdev event
Date: Fri, 7 Apr 2017 14:25:37 -0700 [thread overview]
Message-ID: <1491600340-8359-6-git-send-email-dsa@cumulusnetworks.com> (raw)
In-Reply-To: <1491600340-8359-1-git-send-email-dsa@cumulusnetworks.com>
Nobody cares about the event, so don't send it.
Signed-off-by: David Ahern <dsa@cumulusnetworks.com>
---
drivers/net/bonding/bond_options.c | 2 --
include/linux/netdevice.h | 1 -
include/uapi/linux/if_link.h | 1 -
net/core/rtnetlink.c | 4 ----
4 files changed, 8 deletions(-)
diff --git a/drivers/net/bonding/bond_options.c b/drivers/net/bonding/bond_options.c
index 1bcbb8913e17..533518a64496 100644
--- a/drivers/net/bonding/bond_options.c
+++ b/drivers/net/bonding/bond_options.c
@@ -673,8 +673,6 @@ int __bond_opt_set(struct bonding *bond,
out:
if (ret)
bond_opt_error_interpret(bond, opt, ret, val);
- else if (bond->dev->reg_state == NETREG_REGISTERED)
- call_netdevice_notifiers(NETDEV_CHANGEINFODATA, bond->dev);
return ret;
}
diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
index cc07c3be2705..bd0d26fbec2b 100644
--- a/include/linux/netdevice.h
+++ b/include/linux/netdevice.h
@@ -2279,7 +2279,6 @@ struct netdev_lag_lower_state_info {
#define NETDEV_CHANGEUPPER 0x0015
#define NETDEV_RESEND_IGMP 0x0016
#define NETDEV_PRECHANGEMTU 0x0017 /* notify before mtu change happened */
-#define NETDEV_CHANGEINFODATA 0x0018
#define NETDEV_BONDING_INFO 0x0019
#define NETDEV_PRECHANGEUPPER 0x001A
#define NETDEV_CHANGELOWERSTATE 0x001B
diff --git a/include/uapi/linux/if_link.h b/include/uapi/linux/if_link.h
index 80f3574a4630..a500a12d0131 100644
--- a/include/uapi/linux/if_link.h
+++ b/include/uapi/linux/if_link.h
@@ -909,7 +909,6 @@ enum {
IFLA_EVENT_NOTIFY_PEERS,
IFLA_EVENT_CHANGE_UPPER,
IFLA_EVENT_RESEND_IGMP,
- IFLA_EVENT_CHANGE_INFO_DATA,
IFLA_EVENT_PRE_CHANGE_UPPER,
IFLA_EVENT_CHANGE_LOWER_STATE,
IFLA_EVENT_CHANGE_TX_QUEUE_LEN,
diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c
index 739b06ac3e7f..702723c5db58 100644
--- a/net/core/rtnetlink.c
+++ b/net/core/rtnetlink.c
@@ -1303,9 +1303,6 @@ static int rtnl_fill_link_event(struct sk_buff *skb, unsigned long event)
case NETDEV_RESEND_IGMP:
rtnl_event = IFLA_EVENT_RESEND_IGMP;
break;
- case NETDEV_CHANGEINFODATA:
- rtnl_event = IFLA_EVENT_CHANGE_INFO_DATA;
- break;
case NETDEV_PRECHANGEUPPER:
rtnl_event = IFLA_EVENT_PRE_CHANGE_UPPER;
break;
@@ -4182,7 +4179,6 @@ static int rtnetlink_event(struct notifier_block *this, unsigned long event, voi
case NETDEV_NOTIFY_PEERS:
case NETDEV_CHANGEUPPER:
case NETDEV_RESEND_IGMP:
- case NETDEV_CHANGEINFODATA:
case NETDEV_PRECHANGEUPPER:
case NETDEV_CHANGELOWERSTATE:
case NETDEV_CHANGE_TX_QUEUE_LEN:
--
2.1.4
next prev parent reply other threads:[~2017-04-07 21:25 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-07 21:25 [PATCH net-next 0/8] rtnetlink: Cleanup user notifications for netdev events David Ahern
2017-04-07 21:25 ` [PATCH net-next 1/8] rtnetlink: Do not generate notifications for MTU events David Ahern
2017-04-08 18:06 ` Roopa Prabhu
2017-04-08 18:13 ` David Ahern
2017-04-08 18:18 ` Roopa Prabhu
2017-04-10 15:39 ` Vlad Yasevich
2017-04-10 15:49 ` David Ahern
2017-04-15 1:51 ` Vlad Yasevich
2017-04-15 4:26 ` David Ahern
2017-04-18 7:52 ` Nicolas Dichtel
2017-04-09 1:36 ` Vlad Yasevich
2017-04-09 2:58 ` David Ahern
2017-04-07 21:25 ` [PATCH net-next 2/8] rtnetlink: Do not generate notification for UDP_TUNNEL_PUSH_INFO David Ahern
2017-04-07 21:25 ` [PATCH net-next 3/8] rtnetlink: Do not generate notifications for CHANGEADDR event David Ahern
2017-04-07 21:25 ` [PATCH net-next 4/8] rtnetlink: Do not generate notifications for POST_TYPE_CHANGE event David Ahern
2017-04-07 21:25 ` David Ahern [this message]
2017-04-07 21:25 ` [PATCH net-next 6/8] rtnetlink: Do not generate notifications for PRECHANGEUPPER event David Ahern
2017-04-07 21:25 ` [PATCH net-next 7/8] rtnetlink: Do not generate notifications for NOTIFY_PEERS event David Ahern
2017-04-09 1:37 ` Vlad Yasevich
2017-04-07 21:25 ` [PATCH net-next 8/8] rtnetlink: Do not generate notifications for CHANGELOWERSTATE event David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1491600340-8359-6-git-send-email-dsa@cumulusnetworks.com \
--to=dsa@cumulusnetworks.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=vyasevic@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).