From: Johannes Berg <johannes@sipsolutions.net>
To: Jiri Pirko <jiri@resnulli.us>
Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
pablo@netfilter.org, Jamal Hadi Salim <jhs@mojatatu.com>,
Jiri Benc <jbenc@redhat.com>,
David Ahern <dsa@cumulusnetworks.com>
Subject: Re: [PATCH 1/5] netlink: extended ACK reporting
Date: Sat, 08 Apr 2017 20:37:01 +0200 [thread overview]
Message-ID: <1491676621.5800.24.camel@sipsolutions.net> (raw)
In-Reply-To: <20170408183440.GA1900@nanopsycho> (sfid-20170408_203444_598631_EBE98730)
On Sat, 2017-04-08 at 20:34 +0200, Jiri Pirko wrote:
> nla_total_size(sizeof(u32));
> > + if (extack &&
> > + (extack->missing_attr || extack-
> > >bad_attr))
>
> Attr could be 0, right? I know that on the most of the places 0 is
> UNSPEC, but I'm pretty sure not everywhere.
Yeah, I guess we can't show a missing attribute of 0 now - bad_attr is
a pointer so no problem there.
I think I'll leave it like this - if anyone really wants to say
"attribute 0 is missing" then we can add a flag later... The UAPI does
take this into account by not including the attribute at all if the
data is invalid, so 0 in the userspace API can be done
johannes
next prev parent reply other threads:[~2017-04-08 18:37 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-08 17:48 [PATCH 0/5] extended netlink ACK reporting Johannes Berg
2017-04-08 17:48 ` [PATCH 1/5] netlink: extended " Johannes Berg
2017-04-08 18:26 ` David Ahern
2017-04-08 18:34 ` Jiri Pirko
2017-04-08 18:37 ` Johannes Berg [this message]
2017-04-08 18:40 ` Jiri Pirko
2017-04-08 20:13 ` Johannes Berg
2017-04-09 17:43 ` David Ahern
2017-04-10 6:18 ` Johannes Berg
[not found] ` <1491805089.2455.3.camel-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
2017-04-13 13:27 ` Nicolas Dichtel
2017-04-13 13:29 ` Johannes Berg
[not found] ` <1492090170.29526.1.camel-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
2017-04-13 14:05 ` Nicolas Dichtel
[not found] ` <28b0d93a-7e96-f7eb-b140-afc9ad429c30-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2017-04-13 19:24 ` Johannes Berg
[not found] ` <1492111480.29526.7.camel-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
2017-04-13 21:44 ` Joe Stringer
[not found] ` <CAPWQB7FWOcEen3SGyQtW7t2WpDNLE08JEdHeZHmM738J=Rur0g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-04-18 9:41 ` Johannes Berg
[not found] ` <1492508494.2472.11.camel-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
2017-04-18 23:46 ` Joe Stringer
2017-04-16 14:40 ` second wave of netlink " Jamal Hadi Salim
[not found] ` <826de765-dd18-f6a3-8e37-7b55398ad99b-jkUAjuhPggJWk0Htik3J/w@public.gmane.org>
2017-04-16 14:45 ` David Ahern
[not found] ` <c75ab5ec-d33e-256d-1222-590dd22c5b08-qUQiAmfTcIp+XZJcv9eMoEEOCMrvLtNR@public.gmane.org>
2017-04-16 14:48 ` Jamal Hadi Salim
[not found] ` <280d0c61-4506-f721-1536-4afb2daabef8-jkUAjuhPggJWk0Htik3J/w@public.gmane.org>
2017-04-16 14:50 ` David Ahern
2017-04-16 16:55 ` David Ahern
[not found] ` <20170408174900.12820-2-johannes-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
2017-04-08 18:36 ` [PATCH 1/5] netlink: " David Ahern
[not found] ` <14c58480-cd03-4d61-fffa-fab6e437a7ea-qUQiAmfTcIp+XZJcv9eMoEEOCMrvLtNR@public.gmane.org>
2017-04-08 18:37 ` Johannes Berg
2017-04-08 20:14 ` David Ahern
2017-04-08 17:48 ` [PATCH 2/5] genetlink: pass extended ACK report down Johannes Berg
[not found] ` <20170408174900.12820-1-johannes-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
2017-04-08 17:48 ` [PATCH 3/5] netlink: allow sending extended ACK with cookie on success Johannes Berg
2017-04-08 17:48 ` [PATCH 4/5] netlink: pass extended ACK struct to parsing functions Johannes Berg
[not found] ` <20170408174900.12820-5-johannes-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
2017-04-08 18:50 ` David Ahern
[not found] ` <3077bf17-553d-f9e3-8873-c59fbb26e2aa-qUQiAmfTcIp+XZJcv9eMoEEOCMrvLtNR@public.gmane.org>
2017-04-08 20:15 ` Johannes Berg
2017-04-08 17:49 ` [PATCH 5/5] netlink: pass extended ACK struct where available Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1491676621.5800.24.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=dsa@cumulusnetworks.com \
--cc=jbenc@redhat.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).