* [PATCH net-next] net: ipv6: send unsolicited NA on admin up
@ 2017-04-12 18:49 David Ahern
2017-04-13 11:45 ` Hannes Frederic Sowa
2017-04-17 16:45 ` David Miller
0 siblings, 2 replies; 4+ messages in thread
From: David Ahern @ 2017-04-12 18:49 UTC (permalink / raw)
To: netdev; +Cc: hannes, David Ahern
ndisc_notify is the ipv6 equivalent to arp_notify. When arp_notify is
set to 1, gratuitous arp requests are sent when the device is brought up.
The same is expected when ndisc_notify is set to 1 (per ndisc_notify in
Documentation/networking/ip-sysctl.txt). The NA is not sent on NETDEV_UP
event; add it.
Fixes: 5cb04436eef6 ("ipv6: add knob to send unsolicited ND on link-layer address change")
Signed-off-by: David Ahern <dsa@cumulusnetworks.com>
---
net/ipv6/ndisc.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/net/ipv6/ndisc.c b/net/ipv6/ndisc.c
index b5812b3f7539..b23822e64228 100644
--- a/net/ipv6/ndisc.c
+++ b/net/ipv6/ndisc.c
@@ -1748,6 +1748,8 @@ static int ndisc_netdev_event(struct notifier_block *this, unsigned long event,
case NETDEV_CHANGEADDR:
neigh_changeaddr(&nd_tbl, dev);
fib6_run_gc(0, net, false);
+ /* fallthrough */
+ case NETDEV_UP:
idev = in6_dev_get(dev);
if (!idev)
break;
--
2.1.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH net-next] net: ipv6: send unsolicited NA on admin up
2017-04-12 18:49 [PATCH net-next] net: ipv6: send unsolicited NA on admin up David Ahern
@ 2017-04-13 11:45 ` Hannes Frederic Sowa
2017-04-13 16:41 ` David Ahern
2017-04-17 16:45 ` David Miller
1 sibling, 1 reply; 4+ messages in thread
From: Hannes Frederic Sowa @ 2017-04-13 11:45 UTC (permalink / raw)
To: David Ahern, netdev
On Wed, Apr 12, 2017, at 20:49, David Ahern wrote:
> ndisc_notify is the ipv6 equivalent to arp_notify. When arp_notify is
> set to 1, gratuitous arp requests are sent when the device is brought up.
> The same is expected when ndisc_notify is set to 1 (per ndisc_notify in
> Documentation/networking/ip-sysctl.txt). The NA is not sent on NETDEV_UP
> event; add it.
>
> Fixes: 5cb04436eef6 ("ipv6: add knob to send unsolicited ND on link-layer
> address change")
> Signed-off-by: David Ahern <dsa@cumulusnetworks.com>
Acked-by: Hannes Frederic Sowa <hannes@stressinduktion.org>
In future we might be able to make this a bit more robust when DAD is
happening at the same time.
Thanks,
Hannes
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH net-next] net: ipv6: send unsolicited NA on admin up
2017-04-13 11:45 ` Hannes Frederic Sowa
@ 2017-04-13 16:41 ` David Ahern
0 siblings, 0 replies; 4+ messages in thread
From: David Ahern @ 2017-04-13 16:41 UTC (permalink / raw)
To: Hannes Frederic Sowa, netdev
On 4/13/17 5:45 AM, Hannes Frederic Sowa wrote:
>
>
> On Wed, Apr 12, 2017, at 20:49, David Ahern wrote:
>> ndisc_notify is the ipv6 equivalent to arp_notify. When arp_notify is
>> set to 1, gratuitous arp requests are sent when the device is brought up.
>> The same is expected when ndisc_notify is set to 1 (per ndisc_notify in
>> Documentation/networking/ip-sysctl.txt). The NA is not sent on NETDEV_UP
>> event; add it.
>>
>> Fixes: 5cb04436eef6 ("ipv6: add knob to send unsolicited ND on link-layer
>> address change")
>> Signed-off-by: David Ahern <dsa@cumulusnetworks.com>
>
> Acked-by: Hannes Frederic Sowa <hannes@stressinduktion.org>
>
> In future we might be able to make this a bit more robust when DAD is
> happening at the same time.
agreed.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net-next] net: ipv6: send unsolicited NA on admin up
2017-04-12 18:49 [PATCH net-next] net: ipv6: send unsolicited NA on admin up David Ahern
2017-04-13 11:45 ` Hannes Frederic Sowa
@ 2017-04-17 16:45 ` David Miller
1 sibling, 0 replies; 4+ messages in thread
From: David Miller @ 2017-04-17 16:45 UTC (permalink / raw)
To: dsa; +Cc: netdev, hannes
From: David Ahern <dsa@cumulusnetworks.com>
Date: Wed, 12 Apr 2017 11:49:04 -0700
> ndisc_notify is the ipv6 equivalent to arp_notify. When arp_notify is
> set to 1, gratuitous arp requests are sent when the device is brought up.
> The same is expected when ndisc_notify is set to 1 (per ndisc_notify in
> Documentation/networking/ip-sysctl.txt). The NA is not sent on NETDEV_UP
> event; add it.
>
> Fixes: 5cb04436eef6 ("ipv6: add knob to send unsolicited ND on link-layer address change")
> Signed-off-by: David Ahern <dsa@cumulusnetworks.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-04-17 16:46 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-04-12 18:49 [PATCH net-next] net: ipv6: send unsolicited NA on admin up David Ahern
2017-04-13 11:45 ` Hannes Frederic Sowa
2017-04-13 16:41 ` David Ahern
2017-04-17 16:45 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).