From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Florian Fainelli <f.fainelli@gmail.com>, netdev@vger.kernel.org
Subject: Re: [PATCH 1/8] ftgmac100: Add ethtool n-way reset call
Date: Thu, 13 Apr 2017 10:59:40 +1000 [thread overview]
Message-ID: <1492045180.7236.89.camel@kernel.crashing.org> (raw)
In-Reply-To: <a08e926a-5d8b-cb02-a2dd-1256b255be27@gmail.com>
On Wed, 2017-04-12 at 17:00 -0700, Florian Fainelli wrote:
> > -static int ftgmac100_nway_reset(struct net_device *ndev)
> > +static int ftgmac100_nway_reset(struct net_device *netdev)
> > {
> > - if (!ndev->phydev)
> > + if (!netdev->phydev)
> > return -ENXIO;
> > - return phy_start_aneg(ndev->phydev);
> > + return phy_start_aneg(netdev->phydev);
>
> Can you use phy_ethtool_nway_reset() which does that (and also checks
> if phydev->drv is NULL which would be the case after an unbind).
Ah sure, I didn't notice that one, grepped the wrong driver :-)
I'll respin later today.
Thanks !
Cheers,
Ben.
next prev parent reply other threads:[~2017-04-13 0:59 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-12 22:44 [PATCH 0/8] ftgmac100: Rework batch 5 - Features Benjamin Herrenschmidt
2017-04-12 22:44 ` [PATCH 1/8] ftgmac100: Add ethtool n-way reset call Benjamin Herrenschmidt
2017-04-13 0:00 ` Florian Fainelli
2017-04-13 0:59 ` Benjamin Herrenschmidt [this message]
2017-04-12 22:44 ` [PATCH 2/8] ftgmac100: Add pause frames configuration and support Benjamin Herrenschmidt
2017-04-12 22:44 ` [PATCH 3/8] ftgmac100: Add ndo_set_rx_mode() and support for multicast & promisc Benjamin Herrenschmidt
2017-04-12 22:44 ` [PATCH 4/8] ftgmac100: Add vlan HW offload Benjamin Herrenschmidt
2017-04-12 22:44 ` [PATCH 5/8] ftgmac100: Add netpoll support Benjamin Herrenschmidt
2017-04-12 22:44 ` [PATCH 6/8] ftgmac100: Allow configuration of phy interface via device-tree Benjamin Herrenschmidt
2017-04-13 13:40 ` Andrew Lunn
2017-04-12 22:44 ` [PATCH 7/8] ftgmac100: Display the discovered PHY device info Benjamin Herrenschmidt
2017-04-13 13:40 ` Andrew Lunn
2017-04-12 22:44 ` [PATCH 8/8] ftgmac100: Document device-tree binding Benjamin Herrenschmidt
2017-04-13 13:42 ` Andrew Lunn
2017-04-13 13:58 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1492045180.7236.89.camel@kernel.crashing.org \
--to=benh@kernel.crashing.org \
--cc=f.fainelli@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).