From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gavin Shan Subject: [PATCH v3 net-next 0/8] net/ncsi: Add debugging functionality Date: Tue, 18 Apr 2017 16:51:27 +1000 Message-ID: <1492498295-14385-1-git-send-email-gwshan@linux.vnet.ibm.com> Cc: joe@perches.com, kubakici@wp.pl, davem@davemloft.net, Gavin Shan To: netdev@vger.kernel.org Return-path: Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:41979 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932260AbdDRGwu (ORCPT ); Tue, 18 Apr 2017 02:52:50 -0400 Received: from pps.filterd (m0098409.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.20/8.16.0.20) with SMTP id v3I6maRI112597 for ; Tue, 18 Apr 2017 02:52:39 -0400 Received: from e23smtp02.au.ibm.com (e23smtp02.au.ibm.com [202.81.31.144]) by mx0a-001b2d01.pphosted.com with ESMTP id 29vx44jt0a-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Tue, 18 Apr 2017 02:52:39 -0400 Received: from localhost by e23smtp02.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 18 Apr 2017 16:52:35 +1000 Received: from d23av04.au.ibm.com (d23av04.au.ibm.com [9.190.235.139]) by d23relay07.au.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id v3I6qPkV59113606 for ; Tue, 18 Apr 2017 16:52:33 +1000 Received: from d23av04.au.ibm.com (localhost [127.0.0.1]) by d23av04.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id v3I6q0fE027619 for ; Tue, 18 Apr 2017 16:52:00 +1000 Sender: netdev-owner@vger.kernel.org List-ID: This series supports NCSI debugging infrastructure by adding several debugfs files. It was inspired by the reported issues: No available package and channel are probed successfully. Obviously, we don't have a debugging infrastructure for NCSI stack yet. The first 3 patches, fixing some issues, aren't relevant to the subject. I included them because I expect they can be merged beofre the code for debugging infrastructure. PATCH[4,5,6/8] adds debugfs directories and files to support the debugging infrastructure for several purposes: presenting the NCSI topology; statistics on sent and received NCSI packets; generate NCSI command packet manually. PATCH[7,8/8] fixes two issues found from the debugging functionality. Changelog ========= v3: * Use pr_debug() instead of pr_warn() upon failure to create debugfs directory or file (Joe Perches) * Use relative debugfs path/file names in debug messages in ncsi-debug.c (Joe Perches) * Use const specifier for @ncsi_pkt_handlers and @ranges (Joe Perches) * Eliminate CONFIG_NET_NCSI_DEBUG ifdef's in *.c (Jakub Kicinski) v2: * Use debugfs instead of procfs (Joe Perches) Gavin Shan (8): net/ncsi: Disable HWA mode when no channels are found net/ncsi: Properly track channel monitor timer state net/ncsi: Enforce failover on link monitor timeout net/ncsi: Add debugging infrastructurre net/ncsi: Dump NCSI packet statistics net/ncsi: Support NCSI packet generation net/ncsi: No error report on DP response to non-existing package net/ncsi: Fix length of GVI response packet net/ncsi/Kconfig | 9 + net/ncsi/Makefile | 1 + net/ncsi/internal.h | 105 ++++++ net/ncsi/ncsi-aen.c | 13 +- net/ncsi/ncsi-cmd.c | 13 +- net/ncsi/ncsi-debug.c | 992 +++++++++++++++++++++++++++++++++++++++++++++++++ net/ncsi/ncsi-manage.c | 58 ++- net/ncsi/ncsi-rsp.c | 24 +- 8 files changed, 1203 insertions(+), 12 deletions(-) create mode 100644 net/ncsi/ncsi-debug.c -- 2.7.4