From: Eric Dumazet <eric.dumazet@gmail.com>
To: Martin KaFai Lau <kafai@fb.com>
Cc: Saeed Mahameed <saeedm@dev.mellanox.co.il>,
Gal Pressman <galp@mellanox.com>,
Linux Netdev List <netdev@vger.kernel.org>,
Saeed Mahameed <saeedm@mellanox.com>,
Kernel Team <kernel-team@fb.com>
Subject: Re: [PATCH net v2] net/mlx5e: Fix race in mlx5e_sw_stats and mlx5e_vport_stats
Date: Thu, 20 Apr 2017 08:00:41 -0700 [thread overview]
Message-ID: <1492700441.22296.41.camel@edumazet-glaptop3.roam.corp.google.com> (raw)
In-Reply-To: <20170420141526.maq6b6rgqfjcdyn6@kafai-mba.dhcp.thefacebook.com>
On Thu, 2017-04-20 at 07:15 -0700, Martin KaFai Lau wrote:
> A follow-up patch approach by Gal will be nice.
Note that I had a similar issue on mlx4.
Stats are cleared/reset at open time, but in an asynchronous way.
Using a bonding device ( and fix in
https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git/commit/?id=142c6594acbcc32391af9c15f8cd65c6c177698f ) worked around the problem.
next prev parent reply other threads:[~2017-04-20 15:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-19 23:32 [PATCH net v2] net/mlx5e: Fix race in mlx5e_sw_stats and mlx5e_vport_stats Martin KaFai Lau
2017-04-20 14:00 ` Saeed Mahameed
2017-04-20 14:15 ` Martin KaFai Lau
2017-04-20 14:23 ` Saeed Mahameed
2017-04-20 15:00 ` Eric Dumazet [this message]
2017-04-20 16:50 ` Martin KaFai Lau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1492700441.22296.41.camel@edumazet-glaptop3.roam.corp.google.com \
--to=eric.dumazet@gmail.com \
--cc=galp@mellanox.com \
--cc=kafai@fb.com \
--cc=kernel-team@fb.com \
--cc=netdev@vger.kernel.org \
--cc=saeedm@dev.mellanox.co.il \
--cc=saeedm@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox