From: David Woodhouse <dwmw2@infradead.org>
To: David Miller <davem@davemloft.net>, hauke@hauke-m.de
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
jarod@redhat.com, jogo@openwrt.org, david.heidelberger@ixit.cz,
maillist-linux@barfooze.de, mikko.rapeli@iki.fi
Subject: Re: [PATCH v2 0/3] uapi glibc compat: fix musl libc compatibility
Date: Thu, 20 Apr 2017 21:14:37 +0100 [thread overview]
Message-ID: <1492719277.8404.16.camel@infradead.org> (raw)
In-Reply-To: <20170420.160739.1263793303398330801.davem@davemloft.net>
[-- Attachment #1: Type: text/plain, Size: 911 bytes --]
On Thu, 2017-04-20 at 16:07 -0400, David Miller wrote:
>
> I think I have to put the brakes on this patch series, after much
> consideration.
>
> It does not scale if we continually add a hodge-podge of different
> ifdef tests to the UAPI headers in order to prevent mutliple
> definitions.
>
> We will add that IFF_ECHO ifdef for MUSL libc today, and for another
> libc we will add another such hack. And so on and so forth...
>
> Instead, LIBC implementation must adopt the ifdef protections which
> have standard names and are being adopted by GLIBC and hopefully
> others.
I agree, except I don't think you're going far enough. Those "standard
names" you mention... some of this stuff actually depends on __GLIBC__,
and *that* isn't right either.
I tried to kill that off completely and make the kernel entirely
agnostic, in https://marc.info/?l=linux-api&m=148898383805658&w=2
[-- Attachment #2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 4938 bytes --]
next prev parent reply other threads:[~2017-04-20 20:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-18 21:00 [PATCH v2 0/3] uapi glibc compat: fix musl libc compatibility Hauke Mehrtens
2017-04-18 21:00 ` [PATCH v2 1/3] uapi glibc compat: add libc compat code when not build for kernel Hauke Mehrtens
2017-04-18 21:00 ` [PATCH v2 2/3] uapi glibc compat: fix build if libc defines IFF_ECHO Hauke Mehrtens
2017-04-18 21:00 ` [PATCH v2 3/3] uapi/if_ether.h: prevent redefinition of struct ethhdr Hauke Mehrtens
2017-04-20 20:07 ` [PATCH v2 0/3] uapi glibc compat: fix musl libc compatibility David Miller
2017-04-20 20:14 ` David Woodhouse [this message]
2017-04-20 20:36 ` David Miller
2017-04-21 13:14 ` Hauke Mehrtens
2017-04-21 13:17 ` David Woodhouse
2017-04-21 14:41 ` Rich Felker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1492719277.8404.16.camel@infradead.org \
--to=dwmw2@infradead.org \
--cc=davem@davemloft.net \
--cc=david.heidelberger@ixit.cz \
--cc=hauke@hauke-m.de \
--cc=jarod@redhat.com \
--cc=jogo@openwrt.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maillist-linux@barfooze.de \
--cc=mikko.rapeli@iki.fi \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).