From: Myungho Jung <mhjungk@gmail.com>
To: edumazet@google.com
Cc: netdev@vger.kernel.org
Subject: [PATCH v2] net: core: Prevent from dereferencing null pointer when
Date: Thu, 20 Apr 2017 16:59:20 -0700 [thread overview]
Message-ID: <1492732760-25081-1-git-send-email-mhjungk@gmail.com> (raw)
Added NULL check to make __dev_kfree_skb_irq consistent with kfree
family of functions.
Link: https://bugzilla.kernel.org/show_bug.cgi?id=195289
Signed-off-by: Myungho Jung <mhjungk@gmail.com>
---
Changes in v2:
- Correct category in subject
net/core/dev.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/net/core/dev.c b/net/core/dev.c
index 7869ae3..22be2a6 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -2450,6 +2450,9 @@ void __dev_kfree_skb_irq(struct sk_buff *skb, enum skb_free_reason reason)
{
unsigned long flags;
+ if (unlikely(!skb))
+ return;
+
if (likely(atomic_read(&skb->users) == 1)) {
smp_rmb();
atomic_set(&skb->users, 0);
--
2.7.4
next reply other threads:[~2017-04-20 23:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-20 23:59 Myungho Jung [this message]
2017-04-24 16:02 ` [PATCH v2] net: core: Prevent from dereferencing null pointer when David Miller
2017-04-25 1:00 ` Myungho Jung
2017-04-25 1:10 ` Eric Dumazet
2017-04-25 1:36 ` Myungho Jung
2017-04-25 1:44 ` David Miller
2017-04-25 2:39 ` Myungho Jung
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1492732760-25081-1-git-send-email-mhjungk@gmail.com \
--to=mhjungk@gmail.com \
--cc=edumazet@google.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).